From owner-cvs-all Mon Sep 11 4: 9:51 2000 Delivered-To: cvs-all@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id 346FE37B423 for ; Mon, 11 Sep 2000 04:09:47 -0700 (PDT) Received: (qmail 32513 invoked from network); 11 Sep 2000 11:09:32 -0000 Received: from unknown (HELO bde.zeta.org.au) (203.2.228.102) by gidora.zeta.org.au with SMTP; 11 Sep 2000 11:09:32 -0000 Date: Mon, 11 Sep 2000 22:09:29 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Boris Popov Cc: Doug Rabson , John Baldwin , Doug Rabson , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ktr.h In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 11 Sep 2000, Boris Popov wrote: > On Mon, 11 Sep 2000, Bruce Evans wrote: > > > The KTR_EXTEND version of _TR would be reasonable if it used strncpy() > > instead of snprintf(). _CTR0 seems to have an array overruns from using > > memcpy() instead of strncpy(). The portability given by different _CTR > > macros for different numbers of args is defeated by using gcc's variadic > > macro feature in NULLFSDEBUG(). > > I'll replace it with KASSERT-like definition: > > #define NULLFSDEBUG(args) printf args > > with appropriate changes to the rest of the code. I had almost accepted it. Is the only problem with the KASSERT-like definition that double parentheses must be used when it is invoked? This has the same problem as ITR* -- it messes up all invocations of the macros. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message