From owner-cvs-all@FreeBSD.ORG  Wed Aug 11 16:38:21 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4864816A4CE; Wed, 11 Aug 2004 16:38:21 +0000 (GMT)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 10CF343D5D; Wed, 11 Aug 2004 16:38:21 +0000 (GMT)
	(envelope-from nate@root.org)
Received: from [10.0.0.34] (adsl-67-127-84-57.dsl.snfc21.pacbell.net
	[67.127.84.57])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i7BGcK8U028751;
	Wed, 11 Aug 2004 09:38:20 -0700
Message-ID: <411A4B4F.6070007@root.org>
Date: Wed, 11 Aug 2004 09:37:35 -0700
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 0.7 (X11/20040702)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Don Lewis <truckman@FreeBSD.org>
References: <200408100832.i7A8WmG4013169@gw.catspoiler.org>
In-Reply-To: <200408100832.i7A8WmG4013169@gw.catspoiler.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_shutdown.c vfs_subr.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Aug 2004 16:38:21 -0000

Don Lewis wrote:
> On 10 Aug, Nate Lawson wrote:
> 
>>njl         2004-08-10 01:32:05 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/kern             kern_shutdown.c vfs_subr.c 
>>  Log:
>>  Skip the syncing disks loop if there are no dirty buffers.  Remove a
>>  variable used to flag the initial printf.
>>  
>>  Submitted by:   truckman (earlier version)
>>  
>>  Revision  Changes    Path
>>  1.162     +13 -5     src/sys/kern/kern_shutdown.c
>>  1.519     +1 -1      src/sys/kern/vfs_subr.c
> 
> 
> BDE had a number of objections to this patch.  This is the alternative
> that I came up with:

Feel free to rework/commit it.  I think your patch is a little rough 
still but generally think it's a good idea to reuse the check for nbufs.

-Nate