From owner-cvs-all Wed Jul 17 21:42:45 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5405237B400; Wed, 17 Jul 2002 21:42:40 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id E028543E65; Wed, 17 Jul 2002 21:42:38 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id OAA29410; Thu, 18 Jul 2002 14:42:36 +1000 Date: Thu, 18 Jul 2002 14:46:24 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: John Baldwin Cc: Mark Murray , , Subject: RE: cvs commit: src/sys/i386/include atomic.h In-Reply-To: Message-ID: <20020718143939.M7896-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 17 Jul 2002, John Baldwin wrote: > On 17-Jul-2002 Mark Murray wrote: > > markm 2002/07/17 09:19:37 PDT > > > > Modified files: > > sys/i386/include atomic.h > > Log: > > Clean up the syntax WRT semicolons at the end of function-like-macros, and protect GCCisms from > > non-GNU compilers and lint. > > I would prefer you use #error instead of non-working dummy functions. This file already used #error for that. The purpose of the commit is to specially break this for lint only. I would prefer the file to be correctly ifdefed and fall back to extern functions in cases that can't be implemented inline, much like . Then it could be compiled by any C compiler. The kernel just wouldn't link unless the extern functions were actually implemented somewhere, and might run much slower if they were implemented. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message