From owner-cvs-all Sat Sep 15 14:50:53 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 7D08037B40D; Sat, 15 Sep 2001 14:50:45 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id HAA29415; Sun, 16 Sep 2001 07:50:42 +1000 Date: Sun, 16 Sep 2001 07:50:17 +1000 (EST) From: Bruce Evans X-X-Sender: To: "David E. O'Brien" Cc: , Subject: Re: cvs commit: src/sys/sys cdefs.h In-Reply-To: <200109152110.f8FLAPO61073@freefall.freebsd.org> Message-ID: <20010916073910.C30591-100000@delplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 15 Sep 2001, David E. O'Brien wrote: > obrien 2001/09/15 14:10:25 PDT > > Modified files: > sys/sys cdefs.h > Log: > Allow __FBSDID() to be used without ; > > Revision Changes Path > 1.39 +4 -4 src/sys/sys/cdefs.h I hope that this misfeature was intentionally left out. Using __FBSDID() without a ';' would break would utilities like indent(1) and gtags(1). It then looks like a function definition to indent(1) at least; this causes indent(1) to misindent everything following it. All the code that correctly uses __FBSDID() with a ';' is now uncompilable by C compilers since it has null declarations. The change also breaks __RCSID(). Please back this out. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message