From owner-svn-src-head@FreeBSD.ORG Fri May 29 20:11:37 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 42406106566B; Fri, 29 May 2009 20:11:37 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-ew0-f164.google.com (mail-ew0-f164.google.com [209.85.219.164]) by mx1.freebsd.org (Postfix) with ESMTP id 161DA8FC17; Fri, 29 May 2009 20:11:35 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: by ewy8 with SMTP id 8so3045844ewy.43 for ; Fri, 29 May 2009 13:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:from:date:x-google-sender-auth:message-id:subject:to:cc :content-type:content-transfer-encoding; bh=mo5EDxJnMZoBow43AzXoPBKwQNx1XsQzMermrQ+PjkY=; b=jusenxNhyROMQCv8WqLpg5ytW+9HsMKE6ewDCyjQGzMegWGdzuCLt8H6SNTDzJssSl veMKBnEe5c1QYR7Du8zKwCohz1u+1+jv87J5n9fYQybgGtrdgzfi8dlg1QK301XaHj0g RwbqlFdD1YE9+V1BKGQyt789kaIr8jdiMETVo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=wLnS810Pdfb4rmjq697MKzy7HFgSZo6GH7Cr44xEOucV7DFZTjLj5FEqaoYiKNWs0c RZoqtbAFvKH187mTGxMOU6jZtqu5rSURHcYKXGcnoozVsmU/3ZuApJV/XeEpgWeA28t4 gKGEo3t72DDANDsLlQhkzGY0S2WsKHvo2x4ns= MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.216.6.198 with SMTP id 48mr1068700wen.200.1243627895101; Fri, 29 May 2009 13:11:35 -0700 (PDT) In-Reply-To: <200905291500.n4TF04HM078212@svn.freebsd.org> References: <200905291500.n4TF04HM078212@svn.freebsd.org> From: Ivan Voras Date: Fri, 29 May 2009 22:11:15 +0200 X-Google-Sender-Auth: ed929103f88d03f9 Message-ID: <9bbcef730905291311u5f39708bifbd8af9fad195965@mail.gmail.com> To: Edward Tomasz Napierala Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193041 - head/sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2009 20:11:37 -0000 2009/5/29 Edward Tomasz Napierala : > =C2=A0 =C2=A0 =C2=A0 =C2=A0u_int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mnt_f= lag; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* (i) flags shared w= ith user */ > + =C2=A0 =C2=A0 =C2=A0 u_int =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mnt_xflag= ; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* (i) more flags shared = with user */ I have a trivial question, it probably has to do more with style than with technical issues: why not expand this variable to u_int64 instead of introducing another variable? Atomicity of int access on 32-bit platforms could be an answer but judging from what the variable does, I don't see it being very relevant.