Date: Sun, 08 Mar 2015 18:14:27 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 198379] net/liboping: Update to 1.8.0, Fix MASTER_SITES, WWW, Request MAINTAINER'ship Message-ID: <bug-198379-13-2UDf5JqfzQ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-198379-13@https.bugs.freebsd.org/bugzilla/> References: <bug-198379-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198379 Chris Hutchinson <portmaster@bsdforge.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153970|0 |1 is obsolete| | --- Comment #13 from Chris Hutchinson <portmaster@bsdforge.com> --- Created attachment 154025 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=154025&action=edit svn diff for net/liboping with all modifications as, requested Right you are. I should have known better. :-{ I've changed it, and [of course] it works as intended. Thanks! --Chris --- Comment #14 from Chris Hutchinson <portmaster@bsdforge.com> --- (In reply to Kubilay Kocak from comment #3) > Don't forget ncurses can come from Base *or* Ports. If you can support both, > do so. If you can't, you still want to test both scenarios. Thank you very much for taking the time to review this, Kubilay Kocak. *curses is not an option, and as it is, it will happily use whichever (base, or ports) is available. As to the COMMENT; I modified it so that it better reflected the *current* features/functions. As the original one [currently] "misses the mark". As to: install-target v. ${STRIP_CMD} install-strip wasn't honored (portlint complained) but ${STRIP_CMD} made portlint happy. I'll remove INSTALL_TARGET* as it's redundant. Thanks again, Kubilay Kocak! --Chris (In reply to f0andrey from comment #12) > (In reply to Chris Hutchinson from comment #9) > >> 3) As per original review: STRIP_CMD should take place in post-install. > >> There is still a pre-install: STRIP_CMD > > > > Tried that originally, but there were issues (see additional QA log for > > details). > > This recording allows you to transfer strip of "pre-install:" in > "post-install:" > ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liboping.so.0.2.11 I submitted an updated svn diff to reflect the changes in response to this comment. But bugzilla crashed, complaining about being unable to send an email to the maintainer (matt@peterson.org). So I'm just replying again, in hopes bugzilla doesn't crash this time. Thanks! --Chris -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-198379-13-2UDf5JqfzQ>