From owner-cvs-src@FreeBSD.ORG Sun Dec 7 22:21:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5367B16A4CF for ; Sun, 7 Dec 2003 22:21:07 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 2660D43FEA for ; Sun, 7 Dec 2003 22:21:04 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 36982 invoked by uid 1000); 8 Dec 2003 06:21:06 -0000 Date: Sun, 7 Dec 2003 22:21:06 -0800 (PST) From: Nate Lawson To: Paul Saab In-Reply-To: <20031208051448.87BCD16A53C@hub.freebsd.org> Message-ID: <20031207221626.L36956@root.org> References: <20031208051448.87BCD16A53C@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2003 06:21:07 -0000 On Sun, 7 Dec 2003, Paul Saab wrote: > Modified files: > sys/cam/scsi scsi_da.c > Log: > ciss doesn't like scsi SYNC CACHE. turn it off > > Revision Changes Path > 1.161 +8 -0 src/sys/cam/scsi/scsi_da.c > > --- src/sys/cam/scsi/scsi_da.c:1.160 Wed Oct 8 00:12:30 2003 > +++ src/sys/cam/scsi/scsi_da.c Sun Dec 7 21:14:13 2003 > @@ -376,6 +376,14 @@ > {T_DIRECT, SIP_MEDIA_REMOVABLE, "CREATIVE", "NOMAD_MUVO", "*"}, > /*quirks*/ DA_Q_NO_SYNC_CACHE|DA_Q_NO_PREVENT > }, > + { > + /* > + * The CISS RAID driver drives dont like the cache to be > + * sync'd (esp since write cache is turned off). > + */ > + {T_DIRECT, SIP_MEDIA_FIXED, "COMPAQ", "RAID*", "*"}, > + /*quirks*/ DA_Q_NO_SYNC_CACHE > + }, > }; > > static disk_strategy_t dastrategy; Please place quirks in the proper section. I believe you put that one in the USB section. It would also help if you described what happens when they are sent a SYNC_CACHE (i.e. hang). Most useful would be a PR entry with the dmesg and description of the behavior. The reason for this is that especially in the USB case, many quirks had proliferated that were overly wildcarded and which weren't actually needed but there was no way to be certain which were needed and which weren't. It would be nice to know when we can remove the quirk if this turns out to be an underlying driver problem and not a drive problem. Thanks, Nate