Date: Sun, 31 Aug 2003 21:58:42 +0200 (CEST) From: "Walter C. Pelissero" <walter@pelissero.de> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/56250: ums doesn't work with MCT based PS/2 converters Message-ID: <200308311958.h7VJwg5a074718@hyde.home.loc> Resent-Message-ID: <200308312010.h7VKA8Kh027714@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 56250
>Category: kern
>Synopsis: ums doesn't work with MCT based PS/2 converters
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Aug 31 13:10:07 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator: Walter C. Pelissero
>Release: FreeBSD 4.9-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD hyde.home.loc 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #28: Sun Aug 31 14:33:47 CEST 2003 root@hyde.home.loc:/.amd_mnt/daemon/host/usr/src/sys/compile/PCG-XG9 i386
>Description:
Mice connected to a MCT Corp PS/2 converter don't work. This
seems to be due to a test in ums.c. Changing the test the
device works.
>How-To-Repeat:
Connect to a MCT based USB->PS/2 converter a PS/2 mouse and
try to use it.
>Fix:
The following patch solves the problem, but the possible side
effects are unknown to me. For instance, what happens if
sc->sc_ibuf[0] != sc->sc_iid ?
--- /sys/dev/usb/ums.c Wed Nov 6 21:23:50 2002
+++ ums.c Sun Aug 31 15:08:52 2003
@@ -428,10 +428,8 @@
}
ibuf = sc->sc_ibuf;
- if (sc->sc_iid) {
- if (*ibuf++ != sc->sc_iid)
- return;
- }
+ if (sc->sc_iid)
+ ibuf++;
dx = hid_get_data(ibuf, &sc->sc_loc_x);
dy = -hid_get_data(ibuf, &sc->sc_loc_y);
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308311958.h7VJwg5a074718>