From owner-freebsd-audit  Mon Jul  9 14:15:57 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19])
	by hub.freebsd.org (Postfix) with ESMTP id 9393E37B401
	for <audit@FreeBSD.org>; Mon,  9 Jul 2001 14:15:53 -0700 (PDT)
	(envelope-from mike@coffee.q9media.com)
Received: (from mike@localhost)
	by coffee.q9media.com (8.11.2/8.11.2) id f69LV1H19027;
	Mon, 9 Jul 2001 17:31:01 -0400 (EDT)
	(envelope-from mike)
Date: Mon, 9 Jul 2001 17:31:01 -0400 (EDT)
Message-Id: <200107092131.f69LV1H19027@coffee.q9media.com>
To: Dag-Erling Smorgrav <des@ofug.org>
From: Mike Barcroft <mike@q9media.com>
Cc: audit@FreeBSD.org, Dima Dorfman <dima@unixfreak.org>
Subject: Re: updated src/lib and src/sbin warns patches
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

Dag-Erling Smorgrav <des@ofug.org>
> Mike Barcroft <mike@q9media.com> writes:
> > @@ -12,6 +13,6 @@
> >  	calendar.3 ndaysg.3 calendar.3 ndaysj.3 \
> >  	calendar.3 week.3 calendar.3 weekday.3
> >  
> > -CFLAGS+=-I. -I${.CURDIR} -Wall
> > +CFLAGS+=-I. -I${.CURDIR}
> >  
> >  .include <bsd.lib.mk>
>
> I don't think libcalendar needs the -I stuff, you can remove CFLAGS
> altogether.  Test it in a world build first though.

Quite correct.  Patch updated; world builds without those extra
include paths.  The updated patch is available at the end of this
message and also at:
http://testbed.q9media.net/freebsd/lib.20010709.patch

Best regards,
Mike Barcroft

-----------------------------------------------------------------------

lib.20010709.patch

o Set WARNS?=2 on Makefiles that should have it.
o Remove some useless include paths in libcalendar.
o Tested on i386 and alpha.

Index: libcalendar/Makefile
===================================================================
RCS file: /home/ncvs/src/lib/libcalendar/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- libcalendar/Makefile	2001/03/27 17:26:57	1.5
+++ libcalendar/Makefile	2001/07/09 21:04:19
@@ -1,6 +1,7 @@
 # $FreeBSD: src/lib/libcalendar/Makefile,v 1.5 2001/03/27 17:26:57 ru Exp $
 
 LIB=	calendar
+WARNS?=	2
 
 SRCS=	calendar.c easter.c
 INCS=	calendar.h
@@ -11,7 +12,5 @@
 	calendar.3 gdate.3 calendar.3 jdate.3 \
 	calendar.3 ndaysg.3 calendar.3 ndaysj.3 \
 	calendar.3 week.3 calendar.3 weekday.3
-
-CFLAGS+=-I. -I${.CURDIR} -Wall
 
 .include <bsd.lib.mk>
Index: libnetgraph/Makefile
===================================================================
RCS file: /home/ncvs/src/lib/libnetgraph/Makefile,v
retrieving revision 1.6
diff -u -r1.6 Makefile
--- libnetgraph/Makefile	2001/03/27 17:27:09	1.6
+++ libnetgraph/Makefile	2001/07/09 21:04:19
@@ -2,6 +2,7 @@
 # $Whistle: Makefile,v 1.4 1999/01/17 03:41:02 julian Exp $
 
 LIB=		netgraph
+WARNS?=		2
 MAN=		netgraph.3
 
 SHLIB_MAJOR=	1
@@ -9,8 +10,6 @@
 
 SRCS=		sock.c msg.c debug.c
 INCS=		netgraph.h
-
-CFLAGS+=	-Wall
 
 MLINKS+=	netgraph.3 NgMkSockNode.3
 MLINKS+=	netgraph.3 NgNameNode.3

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message