Date: Wed, 08 Mar 2006 08:52:55 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: scottl@samsco.org Cc: arch@freebsd.org Subject: Re: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c Message-ID: <20060308.085255.50047108.imp@bsdimp.com> In-Reply-To: <440EF0B0.1010203@samsco.org> References: <20060307.233728.42821161.imp@bsdimp.com> <20060308092207.GB679@turion.vk2pj.dyndns.org> <440EF0B0.1010203@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <440EF0B0.1010203@samsco.org>
Scott Long <scottl@samsco.org> writes:
: Peter Jeremy wrote:
: > On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote:
: >
: >>This is the first commit of many to do what the comment says.
: >
: > ...
: >
: >> Log:
: >> Remove leading __ from __(inline|const|signed|volatile). They are
: >> obsolete. This should reduce diffs to NetBSD as well.
: >
: >
: > K&R function definitions are even more obsolete but still used
: > throughout the kernel. IMHO, potential diff-reduction to NetBSD
: > seems a fairly flimsy reason for a significant amount of churn.
: >
: > Also, any diff reduction with NetBSD is probably outweighed by
: > the diff increase with other FreeBSD branches.
: >
: > Maybe this should be treated like whitespace cleanup - something to
: > do if you're going to be doing something non-trivial in the source
: > file. (There are probably other cleanups in the same category).
: >
:
: Yeah, diff increase with other FreeBSD branches is a big deal. While
: sharing between RELENG_4 and more recent branches is pretty hard these
: days, a lot can be shared between RELENG_5, RELENG_6, and HEAD.
Since the universal reaction is negative, I'll not do this unless I'm
already hacking the code for other reasons.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060308.085255.50047108.imp>