From owner-freebsd-current Sun Jan 12 21:47:45 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD5A437B401; Sun, 12 Jan 2003 21:47:43 -0800 (PST) Received: from soulshock.mail.pas.earthlink.net (soulshock.mail.pas.earthlink.net [207.217.120.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20AEA43ED8; Sun, 12 Jan 2003 21:47:43 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from heron (heron.mail.pas.earthlink.net [207.217.120.189]) by soulshock.mail.pas.earthlink.net (8.11.6+Sun/8.11.6) with ESMTP id h0D4uAH09275; Sun, 12 Jan 2003 20:56:10 -0800 (PST) Received: from pool0461.cvx22-bradley.dialup.earthlink.net ([209.179.199.206] helo=mindspring.com) by heron with asmtp (SSLv3:RC4-MD5:128) (Exim 3.33 #1) id 18XwdJ-0001qZ-00; Sun, 12 Jan 2003 20:55:34 -0800 Message-ID: <3E22466B.2F85F2FF@mindspring.com> Date: Sun, 12 Jan 2003 20:54:03 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Marcel Moolenaar Cc: Jake Burkholder , sparc@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: [PATCH] Re: fpsetmask on sparc64 References: <20030112031626.GA15783@rot13.obsecurity.org> <20030112015221.G212@locore.ca> <3E212670.41627B9F@mindspring.com> <20030112032908.H212@locore.ca> <3E216911.B7AFC39F@mindspring.com> <20030112134948.I212@locore.ca> <3E21FDAC.1FD36F5C@mindspring.com> <3E2223F4.5554718E@mindspring.com> <20030113034638.GA2310@dhcp01.pn.xcllnt.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ELNK-Trace: b1a02af9316fbb217a47c185c03b154d40683398e744b8a4e3a81b55ffec6df7c48328fe2fbec06f350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Marcel Moolenaar wrote: > On Sun, Jan 12, 2003 at 06:27:00PM -0800, Terry Lambert wrote: > > Therefore, it seems to me, that the correct place to put them is in > > the header (the other alternative was the > > header; this seemed wrong to me, but I'm willing > > to reroll the patch, if there's a lot of disagreement over this point). > > I would like to see it in : I didn't put it there because that's not where the i386 is getting its version of fpsetmask(), et al. As I said, I'd be happy to reroll the patch, and be overruled. Should I move the i386 inline function and #define's from the machine/floatingpoint.h to the machine/ieeefp.h, as well? It seems to me that all the symbols should come from that place, on all architectures, no matter what place it ends up being. > The synopsis section of our manpage clearly states the inclusion > of . That header file includes a machine dependent > counterpart . On alpha, ia64 and sparc64 > is empty with the exception of the > inclusion of . Actually, on SPARC and i386, it puts _FLOATINGPOINT_H_ into scope, too, while on IA64 and Alpha, it doesn't (which is broken, for the #include #ifndef/#define ... /#endif style). > Hence, I would like to see the prototypes and/or implementation > in . Since on i386 > also includes , we should be able to move > the implementation on i386 to as well. If > possible, I'd like to see retired > unless there's a compelling reason to keep it... Well, that answers my question from above: "yes". 8-). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message