From owner-freebsd-current Mon Jan 31 6: 8:51 2000 Delivered-To: freebsd-current@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id 2F7E415083 for ; Mon, 31 Jan 2000 06:07:18 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id CEF341CD7; Mon, 31 Jan 2000 22:07:15 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: Andrzej Bialecki Cc: current@freebsd.org Subject: Re: make installworld broken??? In-Reply-To: Message from Andrzej Bialecki of "Mon, 31 Jan 2000 11:28:57 +0100." Date: Mon, 31 Jan 2000 22:07:15 +0800 From: Peter Wemm Message-Id: <20000131140715.CEF341CD7@overcee.netplex.com.au> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Andrzej Bialecki wrote: > On Sun, 30 Jan 2000, John Polstra wrote: > > > > > It's source-dir is called "xinstall" btw. > > > Why is the source called "xinstall"? > > > > To avoid colliding with the standard make target "install". If we > > had utilities named "all", "depend", and "clean" we'd have to do the > > same thing for them. > > Mhmmm... Isn't this something that .PHONY target is supposed to handle? No. Consider: PROG= install all: ${PROG} ${PROG}: ${OBJS} cc -o ${PROG} ${OBJS} install: ${INSTALL} .... ${PROG} ${BINDIR} .... and with ${PROG} expanded out: all: install install: ${OBJS} cc -o install ${OBJS} install: ${INSTALL} .... install ${BINDIR} .... Spot the problem.. Does the target "install" mean "build the binary" or "install the binary"? src/usr.bin/xinstall could probably have been named src/usr.bin/install, but PROG has to be xinstall regardless. I guess they kept the two as xinstall for consistancy and in case there were other gotcha's like this. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message