From owner-freebsd-arm@FreeBSD.ORG  Sun Dec 15 23:56:41 2013
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2CB4F502
 for <freebsd-arm@freebsd.org>; Sun, 15 Dec 2013 23:56:41 +0000 (UTC)
Received: from mail-qc0-x229.google.com (mail-qc0-x229.google.com
 [IPv6:2607:f8b0:400d:c01::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D7C881E41
 for <freebsd-arm@freebsd.org>; Sun, 15 Dec 2013 23:56:40 +0000 (UTC)
Received: by mail-qc0-f169.google.com with SMTP id r5so3230963qcx.28
 for <freebsd-arm@freebsd.org>; Sun, 15 Dec 2013 15:56:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=AxdMcSOTGBSPBuMmUjiDA/LXeqLBRHuMU7vbWIsRQv8=;
 b=WPBx8vjjoAVZwJcSETJaiaNNBBeh4crg63IWkKReUjP/j0hg5poiISiQzjDCNlW4i0
 rlrbYuH/WplcCjk7CcWFK670cYVna/dVmhD9xSSwpRfd5Z58B+LKpbFs/cs27Zhz4oqL
 12hkleOexW3GAV/x7PoOEWLBGf+tRH8tf3Ea09ATX1vOQR1A7zQebh68mksMnfnR6W1s
 dCV7eTk/po+dIodOKasQPopXsAjvenGj7oL+KMQct9M1s/qnHvvgppkVxbiD5hS1mR1z
 Cp4v0tV7bi8iDY/XnnC4MHtD/SzEj+dEcKqqIfsli+nG5vZKsIcoox9B1OZCHR0KxRRe
 sDyA==
MIME-Version: 1.0
X-Received: by 10.224.20.202 with SMTP id g10mr27805677qab.66.1387151799534;
 Sun, 15 Dec 2013 15:56:39 -0800 (PST)
Received: by 10.224.130.194 with HTTP; Sun, 15 Dec 2013 15:56:39 -0800 (PST)
In-Reply-To: <20131215173042.0dead636@bender.Home>
References: <CAAvnz_pWZqw-HEB-GTJ_CkErjXrz3v7ozabMXE__vr=SfkBVSg@mail.gmail.com>
 <CAAvnz_p2vw9=HWbGPePKm_yDxM-bM1h6VaQBeJq9sYXPRb2-Lg@mail.gmail.com>
 <20131215173042.0dead636@bender.Home>
Date: Mon, 16 Dec 2013 07:56:39 +0800
Message-ID: <CAAvnz_qmn+a+-aE4GkYw6TDOPzfST2j5WGvHqKX4WWVsVACSzQ@mail.gmail.com>
Subject: Re: [PATCH] Add stack unwind support for the functions in .ko
From: Howard Su <howard0su@gmail.com>
To: Andrew Turner <andrew@fubar.geek.nz>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.17
Cc: freebsd-arm <freebsd-arm@freebsd.org>
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Dec 2013 23:56:41 -0000

On Monday, December 16, 2013, Andrew Turner wrote:

> On Mon, 9 Dec 2013 22:44:14 +0800
> Howard Su <howard0su@gmail.com <javascript:;>> wrote:
>
> > Here is a new version which solve the unreadable $a problem. (the fix
> > is in ddb/db_main.c in the end of the patch.)
> >
> > I attached the diff for review.
>
> I can't comment on the MD parts of the code, but the ARM change looks
> good. My only request is to add a kernel option to turn on printing the
> registers in the stack trace as it has been useful for tracking down
> bugs.
>
I read the MD code of MIPS. seems it faces the same situation like arm
(register pass parameter). I will follow its pattern to print out register.
better than an option?

>
> Andrew
>


-- 
-Howard