From owner-freebsd-hackers@FreeBSD.ORG Sun Apr 6 11:52:15 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2183E37B401 for ; Sun, 6 Apr 2003 11:52:15 -0700 (PDT) Received: from mx03.uni-tuebingen.de (mx03.uni-tuebingen.de [134.2.3.13]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F3A543FAF for ; Sun, 6 Apr 2003 11:52:14 -0700 (PDT) (envelope-from friedemann.becker@student.uni-tuebingen.de) Received: from linux17.zdv.uni-tuebingen.de (linux17.zdv.uni-tuebingen.de [134.2.18.17]) by mx03.uni-tuebingen.de (8.12.3/8.12.3) with ESMTP id h36IqCHY010944 for ; Sun, 6 Apr 2003 20:52:12 +0200 Date: Sun, 6 Apr 2003 20:52:11 +0200 (CEST) From: Friedemann Becker X-Sender: To: In-Reply-To: <000c01c2fbc3$989d8610$0200000a@fireball> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-AntiVirus: checked by AntiVir Milter 1.0.0.8; AVE 6.19.0.3; VDF 6.19.0.5 Subject: [PATCH] Re: systat -v on -CURRENT X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Apr 2003 18:52:15 -0000 I found out, that /usr/src/usr.bin/systat/vmstat.c:dinfo() sometimes calculates -0 for disk utilization. I attatched a patch, that fixed this behaviour and return 0 for negative values of "elapsed time". Could someone take a look at it and commit it, if it's correct? it's a one line + 2 lines of comment patch :-) Friedemann On Sat, 5 Apr 2003, Craig Reyenga wrote: > Date: Sat, 5 Apr 2003 17:34:51 -0500 > From: Craig Reyenga > To: Andre Guibert de Bruet > Cc: freebsd-current@freebsd.org > Subject: Re: systat -v on -CURRENT > > Now that you mention it, Yes: ad2 is -0% busy. > > Disks ad0 ad2 cd0 pass0 ofod intrn > KB/t 0.00 0.00 0.00 0.00 %slo-z 30576 buf > tps 0 0 0 0 tfree 23 dirtybuf > MB/s 0.00 0.00 0.00 0.00 17867 desiredvnodes > % busy 0 -0 0 0 1070 numvnodes > > -Craig > > ----- Original Message ----- > From: "Andre Guibert de Bruet" > To: > Sent: Saturday, April 05, 2003 5:20 PM > Subject: systat -v on -CURRENT > > > > Hi, > > > > I've noticed that 'systat -v' sometimes reports a negative disk activity > > percentile. Has anyone else noticed this behavior? > > > > Before I look into the problem, is someone already working on a fix? > > > > Regards, > > > > > Andre Guibert de Bruet | Enterprise Software Consultant > > > > Silicon Landmark, LLC. | http://siliconlandmark.com/ > > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >