From owner-freebsd-stable@FreeBSD.ORG Thu Sep 17 00:03:13 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 689DB106566C for ; Thu, 17 Sep 2009 00:03:13 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 11A2F8FC0C for ; Thu, 17 Sep 2009 00:03:12 +0000 (UTC) Received: (qmail 14407 invoked by uid 399); 17 Sep 2009 00:03:12 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 17 Sep 2009 00:03:12 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AB17CB9.3040704@FreeBSD.org> Date: Wed, 16 Sep 2009 17:03:05 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Cezary Morga References: <4AAFED75.4020502@andric.com> <4AB099BB.9040603@therek.net> In-Reply-To: <4AB099BB.9040603@therek.net> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: multipart/mixed; boundary="------------000204070209060606020204" Cc: freebsd-stable@freebsd.org Subject: Re: 8.0 rc.d scripts less verbose? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2009 00:03:13 -0000 This is a multi-part message in MIME format. --------------000204070209060606020204 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit First off, this discussion should actually have been on freebsd-current@ until 8.0-RELEASE is done, but that's a minor issue. Cezary Morga wrote: > Dimitry Andric pisze: >> Index: etc/rc.subr >> =================================================================== >> --- etc/rc.subr (revision 196888) >> +++ etc/rc.subr (working copy) >> @@ -680,7 +680,7 @@ run_rc_command() >> >> # setup the full command to run >> # >> - [ -z "${rc_quiet}" ] && echo "Starting ${name}." >> + echo "Starting ${name}." >> if [ -n "$_chroot" ]; then >> _doit="\ >> ${_nice:+nice -n $_nice }\ > > Wouldn't it be easier to set rc_quiet to zero-length value, like > rc_quiet=""? That actually would give off too much information because rc_quiet suppresses error messages about scripts that don't currently have _enable set to anything useful. That's arguably a bug, but it's a bug that we've come to depend on. The attached patch adds a knob you can set in rc.conf to see "Starting foo" messages again. If people find this useful I'll be glad to commit it. I'm also open to suggestions for a better name. Doug -- This .signature sanitized for your protection --------------000204070209060606020204 Content-Type: text/plain; name="rc.subr-starting.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="rc.subr-starting.diff" --- /usr/src/etc/rc.subr 2009-09-16 14:18:07.000000000 -0700 +++ rc.subr 2009-09-16 16:56:39.000000000 -0700 @@ -708,7 +708,7 @@ # setup the full command to run # - [ -z "${rc_quiet}" ] && echo "Starting ${name}." + [ -z "${rc_quiet}" -o -n "${rc_starting}" ] && echo "Starting ${name}." if [ -n "$_chroot" ]; then _doit="\ ${_nice:+nice -n $_nice }\ --------------000204070209060606020204--