From owner-freebsd-bugs@freebsd.org Sat Nov 18 11:58:03 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3187FDB9538 for ; Sat, 18 Nov 2017 11:58:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0F0826D132 for ; Sat, 18 Nov 2017 11:58:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vAIBw2Kq012422 for ; Sat, 18 Nov 2017 11:58:02 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 223327] dhclient: close the pidfile before calling chroot(2) Date: Sat, 18 Nov 2017 11:58:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2017 11:58:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223327 Kristof Provost changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cem@freebsd.org, | |kp@freebsd.org, | |markj@FreeBSD.org, | |oshogbo@freebsd.org --- Comment #1 from Kristof Provost --- Hmm. This is quite interesting. I think the problem started with r322369 wh= ich changed libutil / pidfile_open() to keep the directory fd (rather than the pidfile fd) so it could unlink the pidfile in capability mode. That appears to conflict with chroot now, because you can't chroot if you've got a directory fd open to somewhere outside the new root. I don't think this patch is right, because it'll break the pidfile_remove()= in routehandler(). I'm not at all sure how this should be fixed though. --=20 You are receiving this mail because: You are the assignee for the bug.=