From owner-freebsd-current Tue Jul 17 10:22:23 2001 Delivered-To: freebsd-current@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 76AB637B405 for ; Tue, 17 Jul 2001 10:22:17 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id DAA13722; Wed, 18 Jul 2001 03:22:08 +1000 Date: Wed, 18 Jul 2001 03:19:48 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Ian Dowse Cc: freebsd-current@FreeBSD.ORG Subject: Re: Load average synchronisation and phantom loads In-Reply-To: <200107152319.aa46183@salmon.maths.tcd.ie> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 15 Jul 2001, Ian Dowse wrote: > The patch below causes the samples of running processes to be > somewhat randomised; instead of being taken every 5 seconds, the > gap now varies in the range 4 to 6 seconds, so that synchronisation > should no longer occur. Would there be any objections to my committing > this? I think that is far too much variation. 5 seconds is hard-coded into the computation of the load average (constants in cexp[]), so even a variation of +-1 ticks breaks the computation slightly. > Index: vm/vm_meter.c > =================================================================== > RCS file: /dump/FreeBSD-CVS/src/sys/vm/vm_meter.c,v > retrieving revision 1.57 > diff -u -r1.57 vm_meter.c > --- vm/vm_meter.c 2001/07/04 19:00:12 1.57 > +++ vm/vm_meter.c 2001/07/15 20:54:38 > ... > +SYSINIT(loadav, SI_SUB_PSEUDO, SI_ORDER_ANY, loadav_init, NULL) Not another SYSINIT (all SYSINITs are evil IMO). SI_SUB_PSEUDO is bogus here -- there are no pseudo ttys here. sched_setup() is a good place to do this initialization. > + > Extra blank line. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message