From owner-svn-ports-all@freebsd.org Thu Nov 21 07:18:49 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C51D51B191F; Thu, 21 Nov 2019 07:18:49 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47JWBd4qWxz4050; Thu, 21 Nov 2019 07:18:49 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 6C619520A; Thu, 21 Nov 2019 07:18:49 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (110.40.91.92.rev.sfr.net [92.91.40.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 20FE0942F8F; Thu, 21 Nov 2019 07:18:48 +0000 (UTC) Date: Thu, 21 Nov 2019 08:18:47 +0100 From: Mathieu Arnold To: Tobias Kortkamp Cc: Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r518052 - head/sysutils/am-utils Message-ID: <20191121071847.6564ybobj4ennhcy@atuin.in.mat.cc> References: <201911202129.xAKLTikX056001@repo.freebsd.org> <20191121070924.GA50105@urd.tobik.me> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wcbpoteyztvskbdz" Content-Disposition: inline In-Reply-To: <20191121070924.GA50105@urd.tobik.me> User-Agent: NeoMutt/20180716 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 07:18:49 -0000 --wcbpoteyztvskbdz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 21, 2019 at 08:09:24AM +0100, Tobias Kortkamp wrote: > On Wed, Nov 20, 2019 at 09:29:44PM +0000, Cy Schubert wrote: > > Author: cy > > Date: Wed Nov 20 21:29:44 2019 > > New Revision: 518052 > > URL: https://svnweb.freebsd.org/changeset/ports/518052 > >=20 > > Log: > > Make the installation of the rc script conditional to avoid conflict > > with base. > > =20 > > MFH: 2019Q4 > > [...] > > -USE_RC_SUBR=3D amd > > +RC_USE_RC_SUBR=3D amd >=20 > There is no such options helper. It should be >=20 > RC_USE=3D RC_SUBR=3Damd >=20 > Also the rc script seems to still use /usr/sbin/amd instead of > %%PREFIX%%/sbin/amd which should probably be fixed too. Also, I am unsure of the use of this rc script, if it has the same name as the base system one, they will have the same variables controlling them, and both will be started at boot time if amd_enable=3Dyes, which is probably not what is wanted here. --=20 Mathieu Arnold --wcbpoteyztvskbdz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl3WOldfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjiBw/+I/ejcoalh8k4NWuCr7g7mE9j8iflAnfC2QLXQnw5y0s7spgw7rtbpcKo jkk+gtt0dJK9pTdi9SPMMIl+p/t2ugLBUU0D18TXqZifogLoDSIx+2bCWH2b1Fwk FzTs7HISkuA3aEPebCMKjESkm4wvf3U7E+MmIRHwdTqa6PPz9WHDWOXEwTNVjJ3I FfLKBSdl83Rm3Qjt3eW1SP2xILC3gFNzdM7AF/Cig2mk8gP49wPCB9J0IJCQygjD KJsFAfz/3Xeh8tnjIucoqydlkhMmt+rVZ3ypPmDMjApitSd9fDmtmjaHzI3ckSVo 5F03QdPVtwsmhrzOUmzE2tCJHC9zG9l4JsZxyUjKgWzE3y4g0ZRe2nntQvE8IURs WtKfQQZz29S30KHraK2SLDaDaqGYPPtFM8UvpzJl+rPNVOdpt6liPvf9r/Nj5jic Ynsy0foLm4hpT9fokQWjmKhCBMMj71blyZPBji+YxAoaX1+HZHdnhP0ffbfv98zo tVwkzN6fsqqo8GK4KCjfiO51sI22jdrj+0VGqCeP4+JdgoKuocQ1i9W/OTDIQ6/X 1lTMy9/70/Eh5MN39apSzJc+NEEmM6fj+065VlYUwJI9zneCkk5Cf8ZSkT73CJyv bNKSq43pNI+/SKttst9uTT/4t9T68EJXRoAtusjvRD/frqZ+6HI= =JiZp -----END PGP SIGNATURE----- --wcbpoteyztvskbdz--