From owner-dev-commits-src-all@freebsd.org Wed Feb 17 21:17:54 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E9EF053355A; Wed, 17 Feb 2021 21:17:54 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgrKG62MWz3QcZ; Wed, 17 Feb 2021 21:17:54 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x72c.google.com with SMTP id x14so101616qkm.2; Wed, 17 Feb 2021 13:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2kKM0vSiLjLXI3YLj8VV1qfIi+4oP79gApR52c8ph/k=; b=TAmqXNeIgPHlFhNSoUsYW4ow9yYKMJ9c7qM+hDiPr0oEpQtI4pt2r5vzQTfWCwvyaA oj1syUR5oA07XOPxrJhnf0KyDXDJkXA6TE0jmYPYqMoUx0LslaU6DA0zKuP5HHVQiXqH zmLIwBMFt7JlEq70Zbn4G9RGNaCyo5FgbCQf0vsLDI/1heItM8qbV3tyGAe1FClfAs3j 0P/Xso1EOkbdbdDeakWNHeIMRFOPUDGSnFLn46A+DBhDk/ufCx1RHezXu3a8gNYWDUeD aDvYyUT63G8TqGO5NvmxIoKX7ElbIQxVGJp82qwkiaAsedZWbxejVyzVIbv8UcT2pUtk ioPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=2kKM0vSiLjLXI3YLj8VV1qfIi+4oP79gApR52c8ph/k=; b=qNourubezC4ypoh2Wp0yJyVEiMyH7hVrYv1MEzYAO2iCHuqAwUZq3ioqt11DAenCqo qkCuW8rnCOA4BuZ65C70mbCP8VONlRqfVng2c5JBQ79L2lgXJfVw8sb4pIZx1SSCIoXh KXmk7uyg3am+ZFCsjX7AicSScvzgOrS53Cb9cjkw3iMEUPLp8TN0lmH//6+RNLCQsVdx u192iiz+U789VEohAPwVeFVZgYEIgOuu0v0SxFQkIOJoFd7dGSxcNlkb8r6Rc1EEpHQs dp/I1btAfIWuCN8qzfQQXlcs85GTCwbXCAcR4G6nKImo9gYHXf5BxRg9JDyVroxiM7y+ qHWA== X-Gm-Message-State: AOAM532ZSdFTQEgIJSLtqN7lSeE5f3aDTmmo7B6dxhAltfjRs27utedy BCOQp2HD/1kFShTc/Ca6cbJbQGi8XY0= X-Google-Smtp-Source: ABdhPJxL4jed6d7iG71SLHV2Iltaa0oondFw5XS2L9vbZSGna93kWBKYHXis/hYNDmcwugvSXmzlVA== X-Received: by 2002:a37:806:: with SMTP id 6mr1197285qki.258.1613596673688; Wed, 17 Feb 2021 13:17:53 -0800 (PST) Received: from nuc ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id d1sm2389849qkj.123.2021.02.17.13.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 13:17:53 -0800 (PST) Sender: Mark Johnston Date: Wed, 17 Feb 2021 16:17:54 -0500 From: Mark Johnston To: "Hartmann, O." Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8ba333e02eaa - main - libdtrace: Stop relying on lex compatibility Message-ID: References: <202102171602.11HG2FVf099522@gitrepo.freebsd.org> <20210217214505.0d4b544e@hermann.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210217214505.0d4b544e@hermann.fritz.box> X-Rspamd-Queue-Id: 4DgrKG62MWz3QcZ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 21:17:55 -0000 On Wed, Feb 17, 2021 at 09:45:05PM +0100, Hartmann, O. wrote: > On Wed, 17 Feb 2021 16:02:15 GMT > Mark Johnston wrote: > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=8ba333e02eaa59337a4e1d5534d4e894344c8226 > > > > commit 8ba333e02eaa59337a4e1d5534d4e894344c8226 > > Author: Mark Johnston > > AuthorDate: 2021-02-17 15:49:38 +0000 > > Commit: Mark Johnston > > CommitDate: 2021-02-17 15:57:19 +0000 > > > > libdtrace: Stop relying on lex compatibility > > > > It does not appear to be required, and as of commit 6b7e592c215f > > ("lex: Do not let input() return 0 when end-of-file is reached") it > > causes input to return 0 instead of EOF when end-of-input is reached. > > > > PR: 253440 > > MFC after: 3 days > > Sponsored by: The FreeBSD Foundation > > --- > > cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h | 2 +- > > cddl/lib/libdtrace/Makefile | 2 -- > > 2 files changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h > > b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h index > > f2c60a2b07d4..b3f69bb6329d 100644 --- > > a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h +++ > > b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_impl.h @@ -717,7 +717,7 @@ extern > > dt_pcb_t *yypcb; /* pointer to current parser control block */ extern > > char yyintprefix; /* int token prefix for macros (+/-) */ extern char > > yyintsuffix[4]; /* int token suffix ([uUlL]*) */ extern int yyintdecimal; > > /* int token is decimal (1) or octal/hex (0) */ -extern char yytext[]; > > /* lex input buffer */ +extern char *yytext; /* lex input buffer */ > > extern int yylineno; /* lex line number */ > > extern int yydebug; /* lex debugging */ > > extern dt_node_t *yypragma; /* lex token list for control lines */ > > diff --git a/cddl/lib/libdtrace/Makefile b/cddl/lib/libdtrace/Makefile > > index efd73751e2c0..45ca1692cf48 100644 > > --- a/cddl/lib/libdtrace/Makefile > > +++ b/cddl/lib/libdtrace/Makefile > > @@ -129,8 +129,6 @@ SRCS+= dis_tables.c > > DSRCS+= regs_x86.d > > .endif > > > > -LFLAGS+=-l > > - > > YFLAGS+=-d > > > > LIBADD= ctf elf proc pthread rtld_db > > _______________________________________________ > > dev-commits-src-main@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebsd.org" > > This commit breaks buildworld (also breask starting from scratch/clean /usr/obj): I'm surprised that it breaks with a clean buildworld. Can you verify from the build logs that dt_lex.c is being re-generated during the libdtrace build?