From owner-cvs-all@FreeBSD.ORG Wed Oct 12 16:43:51 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF2E716A41F; Wed, 12 Oct 2005 16:43:50 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5682E43D45; Wed, 12 Oct 2005 16:43:50 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j9CGh05Q055723; Wed, 12 Oct 2005 10:43:00 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 12 Oct 2005 10:43:00 -0600 (MDT) Message-Id: <20051012.104300.74694006.imp@bsdimp.com> To: ru@freebsd.org From: Warner Losh In-Reply-To: <20051012152710.GC75270@ip.net.ua> References: <200510121009.j9CA9aE3026075@repoman.freebsd.org> <20051012.091330.53066886.imp@bsdimp.com> <20051012152710.GC75270@ip.net.ua> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 12 Oct 2005 10:43:00 -0600 (MDT) Cc: cvs-src@freebsd.org, yar@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/make make.1 X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2005 16:43:51 -0000 From: Ruslan Ermilov Subject: Re: cvs commit: src/usr.bin/make make.1 Date: Wed, 12 Oct 2005 18:27:10 +0300 > On Wed, Oct 12, 2005 at 09:13:30AM -0600, M. Warner Losh wrote: > > In message: <200510121009.j9CA9aE3026075@repoman.freebsd.org> > > Yar Tikhiy writes: > > : yar 2005-10-12 10:09:36 UTC > > : > > : FreeBSD src repository > > : > > : Modified files: > > : usr.bin/make make.1 > > : Log: > > : __MAKE_CONF doesn't really belong here because it is > > : a FreeBSD extension of sys.mk. A xref to make.conf(5) > > : will be enough here. > > : > > : Requested by: ru > > > > I disagree. It is already hard enough to find info about __MAKE_CONF, > > and since it is part of the base system, this seems like an artificial > > distinction. > > > __MAKE_CONF doesn't fall under "make sets or knows about the following > internal variables or environment variables". Rather, it's a FreeBSD > specific feature, it doesn't have any direct connection to the make > utility (as well as CPUTYPE, CFLAGS, etc.). As such, it shouldn't > be documented in the make(1) manpage. OTOH, build(7) could benefit > from talking more about make.conf(5), while having __MAKE_CONF only > documented in make.conf(5) is fine. We really don't need any more > duplication. I disagree. It is directly connected to the make(1) utility, just like all the FreeBSD extentions we've added over the years for things like 'expand this variable, and make it upper case'. Every single invocation of make(1) will cause __MAKE_CONF to be evalutated, and /etc/make.conf included if __MAKE_CONF isn't defined. It is very much unlike CPUTYPE, CFLAGS, etc because of this. As such, it should be in the make(1) man page. Every user of make potentially has to know about it. It is a variable that we've made fundamental to our make system, so it should be at least mentioned in make(1). There's no harm in putting it make(1), and people absolutely will look there first for this information. A simple xref to make.conf isn't sufficient. Warner