From owner-svn-src-head@freebsd.org Mon Jun 17 10:34:17 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0162615B41A1; Mon, 17 Jun 2019 10:34:17 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 63FB8898E8; Mon, 17 Jun 2019 10:34:16 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 45S6yZ4SL0z3klb; Mon, 17 Jun 2019 10:34:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new, port 10587) with ESMTPS id qUZg-OtU6PsV; Mon, 17 Jun 2019 10:34:14 +0000 (UTC) Received: from garnet.daemonic.se (host-90-236-237-150.mobileonline.telia.com [90.236.237.150]) by mail.daemonic.se (Postfix) with ESMTPSA id 45S6yY5dXtz3c7W; Mon, 17 Jun 2019 10:34:13 +0000 (UTC) Subject: Re: svn commit: r349133 - head/share/man/man4 From: Niclas Zeising To: rgrimes@freebsd.org Cc: Benjamin Kaduk , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers References: <201906170903.x5H93Wac008131@gndrsh.dnsmgr.net> <4e64bb67-7e4b-cd2d-7690-b6be11d78f58@freebsd.org> Message-ID: Date: Mon, 17 Jun 2019 12:34:13 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <4e64bb67-7e4b-cd2d-7690-b6be11d78f58@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 63FB8898E8 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.965,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jun 2019 10:34:17 -0000 On 2019-06-17 12:27, Niclas Zeising wrote: > On 2019-06-17 11:03, Rodney W. Grimes wrote: >>> On 2019-06-17 09:56, Benjamin Kaduk wrote: >>>> On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising >>> > wrote: >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Author: zeising (doc,ports committer) >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Date: Mon Jun 17 05:41:47 2019 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 New Revision: 349133 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 URL: https://svnweb.freebsd.org/changeset/b= ase/349133 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Log: >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? pci(4): Document PCIOCATTACHED >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? Document the PCIOCATTACHED ioctl(2)= in the pci(4) manual. >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? PCIOCATTACHED is used to query if a= driver has attached to a=20 >>>> PCI. >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? Reviewed by:? bcr, imp >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? MFC after:? ? 2 weeks >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? Differential Revision: https://revi= ews.freebsd.org/D20652 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Modified: >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ? head/share/man/man4/pci.4 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 Modified: head/share/man/man4/pci.4 >>>> =20 >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=20 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 --- head/share/man/man4/pci.4? ?Mon Jun 17 = 03:48:44 2019 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 (r349132) >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +++ head/share/man/man4/pci.4? ?Mon Jun 17 = 05:41:47 2019 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 (r349133) >>>> =C2=A0=C2=A0=C2=A0=C2=A0 @@ -24,7 +24,7 @@ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.\" >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.\" $FreeBSD$ >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.\" >>>> =C2=A0=C2=A0=C2=A0=C2=A0 -.Dd June 14, 2018 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +.Dd June 17, 2019 >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.Dt PCI 4 >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.Os >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.Sh NAME >>>> =C2=A0=C2=A0=C2=A0=C2=A0 @@ -333,6 +333,26 @@ The limitations on dat= a width described for >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?reading registers, above, also apply= to writing >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?.Tn PCI >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ?configuration registers. >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +.It PCIOCATTACHED >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +This >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +.Xr ioctl 2 >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +allows users to query if a driver is attac= hed to the >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +.Tn PCI >>>> =C2=A0=C2=A0=C2=A0=C2=A0 +specified in the passed-in >>>> >>>> >>>> Is there a missing word like "device" here? >> >> Actally I think the missing word, in both cases, is register, >> unless I am misreading some part of the manual page and >> what a struct pci_io points at.=C2=A0 I guess if the pi_reg is null >> then this would be device.=C2=A0 Either way there is defanity a >> missing word. >=20 > I'll try to fix this.=C2=A0 In the PCIOCWRITE case, perhaps register is= best,=20 > however, inthe PCIOCATTACHED case, device is best, I think. > I'll create a patch and put it for review, I'll get back to you once=20 > it's done. > Regards >=20 Here's the review with my proposed change. Let me know what you think. https://reviews.freebsd.org/D20671 Regards --=20 Niclas Zeising