Date: Mon, 31 May 2021 16:31:05 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 256301] bsd.port.mk: fix setting of FLAVOR in _FLAVOR_RECURSIVE_SH Message-ID: <bug-256301-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256301 Bug ID: 256301 Summary: bsd.port.mk: fix setting of FLAVOR in _FLAVOR_RECURSIVE_SH Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: avg@FreeBSD.org CC: ports-bugs@FreeBSD.org There are several ways of handling recursive targets. I found at least Mk/Scripts/do-depends.sh Mk/Scripts/depends-list.sh _FLAVOR_RECURSIVE_SH It looks that the latter has a couple of problems comparing to others. First, it does not handle '@' in a port name. Second, it would set FLAVOR to the empty value even if a package is not "flavored". That can confuse some ports. A fast demonstration of the second problem: $ make -C /usr/ports/lang/gcc9 checksum-recursive ... =3D=3D=3D> native-binutils-2.33.1_4,1 depends on file: /usr/local/sbin/pk= g - found =3D=3D=3D> Fetching all distfiles required by native-binutils-2.33.1_4,1 fo= r building ... Note how the package name is native-binutils instead of binutils. A longer demonstration of the problem would be with the package-resursive target. That issue was reported and analyzed some time ago, unfortunately with no action: https://www.mail-archive.com/freebsd-ports@freebsd.org/msg84543.= html The proposed change brings _FLAVOR_RECURSIVE_SH closer to the other recursion methods and it should fix both of the problems: https://reviews.freebsd.org/D30579 --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-256301-7788>