From owner-p4-projects@FreeBSD.ORG Sat Jun 14 03:13:17 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3164D106566C; Sat, 14 Jun 2008 03:13:17 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E79F1106567B for ; Sat, 14 Jun 2008 03:13:16 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D9BF58FC14 for ; Sat, 14 Jun 2008 03:13:16 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m5E3DGwI098519 for ; Sat, 14 Jun 2008 03:13:16 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m5E3DGro098517 for perforce@freebsd.org; Sat, 14 Jun 2008 03:13:16 GMT (envelope-from hselasky@FreeBSD.org) Date: Sat, 14 Jun 2008 03:13:16 GMT Message-Id: <200806140313.m5E3DGro098517@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Cc: Subject: PERFORCE change 143434 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jun 2008 03:13:17 -0000 http://perforce.freebsd.org/chv.cgi?CH=143434 Change 143434 by hselasky@hselasky_laptop001 on 2008/06/14 03:13:05 USB Lookup: Clearify that the above and below macros are inclusive. Remove test code from "usb2_lookup.c". Affected files ... .. //depot/projects/usb/src/sys/dev/usb2/core/usb2_lookup.c#2 edit .. //depot/projects/usb/src/sys/dev/usb2/core/usb2_lookup.h#2 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb2/core/usb2_lookup.c#2 (text+ko) ==== @@ -102,9 +102,3 @@ done: return (0); } - -struct usb2_device_id test = { - - USB_VENDOR(0), USB_PRODUCT(0), USB_VP(0, 0), USB_DEV_BCD_BELOW(0), USB_DEV_BCD_ABOVE(0), USB_DEV_CLASS(0), USB_DEV_SUBCLASS(0), USB_DEV_PROTOCOL(0), USB_IFACE_CLASS(0), USB_IFACE_SUBCLASS(0), USB_IFACE_PROTOCOL(0), USB_DRIVER_INFO(0), USB_MATCH_END(0), - -}; ==== //depot/projects/usb/src/sys/dev/usb2/core/usb2_lookup.h#2 (text+ko) ==== @@ -93,10 +93,10 @@ #define USB_VP(vend,prod) \ USB_VENDOR(vend), USB_PRODUCT(prod) -#define USB_DEV_BCD_BELOW(lo) \ +#define USB_DEV_BCD_LTEQ(lo) /* less than or equal */ \ .match_flag_dev_lo = 1, .bcdDevice_lo = (lo) -#define USB_DEV_BCD_ABOVE(hi) \ +#define USB_DEV_BCD_GTEQ(hi) /* greater than or equal */ \ .match_flag_dev_hi = 1, .bcdDevice_hi = (hi) #define USB_DEV_CLASS(dc) \