From owner-cvs-src@FreeBSD.ORG Mon Jun 4 11:31:46 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9D68916A400; Mon, 4 Jun 2007 11:31:46 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 8E81813C46C; Mon, 4 Jun 2007 11:31:46 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l54BVkqZ099573; Mon, 4 Jun 2007 11:31:46 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l54BVkpc099569; Mon, 4 Jun 2007 11:31:46 GMT (envelope-from pjd) Message-Id: <200706041131.l54BVkpc099569@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Mon, 4 Jun 2007 11:31:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/opensolaris/kern opensolaris_vfs.c src/sys/compat/opensolaris/sys vfs.h src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_ctldir.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2007 11:31:46 -0000 pjd 2007-06-04 11:31:46 UTC FreeBSD src repository Modified files: sys/compat/opensolaris/kern opensolaris_vfs.c sys/compat/opensolaris/sys vfs.h sys/contrib/opensolaris/uts/common/fs/zfs zfs_ctldir.c Log: Reimplement traverse() helper function: 1. Pass locking flags to VFS_ROOT(). 2. Check v_mountedhere while the vnode is locked. 3. Always return locked vnode on success. Change 1 fixes problem reported by Stephen M. Rumble - after zfs_vfsops.c,1.9 change, zfs_root() no longer locks the vnode unconditionally and traverse() didn't pass right lock type to VFS_ROOT(). The result was that kernel paniced when .zfs/ directory was accessed via NFS. Revision Changes Path 1.6 +14 -10 src/sys/compat/opensolaris/kern/opensolaris_vfs.c 1.2 +2 -2 src/sys/compat/opensolaris/sys/vfs.h 1.5 +9 -10 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c