From owner-svn-src-all@FreeBSD.ORG Sat Apr 11 17:04:05 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 793DB106564A; Sat, 11 Apr 2009 17:04:05 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qy0-f134.google.com (mail-qy0-f134.google.com [209.85.221.134]) by mx1.freebsd.org (Postfix) with ESMTP id CED068FC13; Sat, 11 Apr 2009 17:04:04 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by qyk40 with SMTP id 40so2576052qyk.3 for ; Sat, 11 Apr 2009 10:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=xLNa8/3640t3tKDSWzl+GM4SH3iFPhNYdqYKYhYEKn4=; b=LdkvLe1VGQ8Y+3+785K1op3jZ9z7h/Rnsb/qEzBmKPOCoxdXxvs2g8tfSPEGtKGQGg 0Ab+3ttpyiHODVzpPP1wjnneWiGAMF8sHMU2dOVnKx19/b6XPtexibmDFiHSKuPypqY8 iWhedukuGo6FTREfcqxtPu+VEpyC6yhfrqRvI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=WSYTlzo1olLTDpNJ0JJvUVMsmWS8ZU9XmX1Gk8IOL+3psdDonftf0FaJTHcXf08OGo hUThVgWWeaRAHUVAWRYb4gU4SRbhVEvLMrPfUQ8l3HBESAoE5LpolkosaFeEumA/N+27 4+9CbnpJrC8kMcLwesS0c4QWqL1yDnqTs8rLA= Received: by 10.224.67.67 with SMTP id q3mr4885570qai.5.1239468225036; Sat, 11 Apr 2009 09:43:45 -0700 (PDT) Received: from kan.dnsalias.net (c-98-217-224-113.hsd1.ma.comcast.net [98.217.224.113]) by mx.google.com with ESMTPS id 26sm4615937qwa.52.2009.04.11.09.43.41 (version=SSLv3 cipher=RC4-MD5); Sat, 11 Apr 2009 09:43:43 -0700 (PDT) Date: Sat, 11 Apr 2009 12:43:35 -0400 From: Alexander Kabaev To: Steve Kargl Message-ID: <20090411124335.0600a72f@kan.dnsalias.net> In-Reply-To: <20090411163528.GC46526@troutmask.apl.washington.edu> References: <200904111401.n3BE1108088009@svn.freebsd.org> <20090411163528.GC46526@troutmask.apl.washington.edu> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.14.7; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/nbr_NUpyatGoY_GpH4Sseq7"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Schouten Subject: Re: svn commit: r190919 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2009 17:04:05 -0000 --Sig_/nbr_NUpyatGoY_GpH4Sseq7 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 11 Apr 2009 09:35:28 -0700 Steve Kargl wrote: > On Sat, Apr 11, 2009 at 02:01:01PM +0000, Ed Schouten wrote: > > Author: ed > > Date: Sat Apr 11 14:01:01 2009 > > New Revision: 190919 > > URL: http://svn.freebsd.org/changeset/base/190919 > >=20 > > Log: > > Simplify in/out functions (for i386 and AMD64). > > =20 > > Remove a hack to generate more efficient code for port numbers > > below 0x100, which has been obsolete for at least ten years, > > because GCC has an asm constraint to specify that. > > =20 > > Submitted by: Christoph Mallon > >=20 >=20 > I thought Christoph and bde were still hashing out the correctness > of this patch. >=20 > http://lists.freebsd.org/pipermail/freebsd-amd64/2009-April/012064.html >=20 > --=20 > Steve The patch is inconsistent in regards to usage of volatile vs. __volatile even within itself. I think the code is sloppy and was not ready to be committed yet. Please fix or back out. --=20 Alexander Kabaev --Sig_/nbr_NUpyatGoY_GpH4Sseq7 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iD8DBQFJ4Mi8Q6z1jMm+XZYRAs1wAJ9R0s0eYED/siLAQ9OMMQAYThLKLgCgy/gX i3ACSeLv6QxxoP1TYXumCok= =WmK8 -----END PGP SIGNATURE----- --Sig_/nbr_NUpyatGoY_GpH4Sseq7--