From owner-cvs-src@FreeBSD.ORG  Sun Feb 27 01:15:12 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E29C816A4CE; Sun, 27 Feb 2005 01:15:12 +0000 (GMT)
Received: from ylpvm01.prodigy.net (ylpvm01-ext.prodigy.net [207.115.57.32])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 898CD43D5E; Sun, 27 Feb 2005 01:15:12 +0000 (GMT)
	(envelope-from nate@root.org)
Received: from [10.0.0.115] (adsl-64-171-186-189.dsl.snfc21.pacbell.net
	[64.171.186.189])j1R1FAvE019838;	Sat, 26 Feb 2005 20:15:11 -0500
Message-ID: <42211F1D.30801@root.org>
Date: Sat, 26 Feb 2005 17:15:09 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041205)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Marcel Moolenaar <marcel@FreeBSD.org>, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org, src-committers@FreeBSD.org
References: <20050227002323.AEFC716A55A@hub.freebsd.org>
In-Reply-To: <20050227002323.AEFC716A55A@hub.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: cvs commit: src/usr.sbin/powerd powerd.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Feb 2005 01:15:13 -0000

Marcel Moolenaar wrote:
> marcel      2005-02-27 00:23:19 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     usr.sbin/powerd      powerd.c 
>   Log:
>   Unbreak !i386 platforms. Only i386 has APM, so don't try to fallback
>   on APM on other platforms.
>   
>   Revision  Changes    Path
>   1.3       +11 -1     src/usr.sbin/powerd/powerd.c

Thanks.  It would be cleaner to move this code into apm_init_ac() and 
acpm_get_ac() functions so the ifdef could be in just one place.

I think there is also one other issue.  It would be cleaner to check for 
the acpi sysctl in the rc.d script and return immediately rather than 
starting powerd and it bombing out once it discovers this.  Patches 
welcome since my rc-familiarity is quite low.

-- 
Nate