From owner-freebsd-arch@FreeBSD.ORG  Mon Oct 26 19:25:04 2009
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9B99A106566C;
	Mon, 26 Oct 2009 19:25:04 +0000 (UTC)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3])
	by mx1.freebsd.org (Postfix) with ESMTP id 52AFB8FC0A;
	Mon, 26 Oct 2009 19:25:04 +0000 (UTC)
Received: from localhost (amavis.fra.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id CA66A41C70C;
	Mon, 26 Oct 2009 20:05:06 +0100 (CET)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([195.88.108.3])
	by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id 9fEz-mZR9xr9; Mon, 26 Oct 2009 20:05:06 +0100 (CET)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id 2F67E41C6EA; Mon, 26 Oct 2009 20:05:06 +0100 (CET)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id CB6F74448E6;
	Mon, 26 Oct 2009 19:00:22 +0000 (UTC)
Date: Mon, 26 Oct 2009 19:00:22 +0000 (UTC)
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: John Baldwin <jhb@freebsd.org>
In-Reply-To: <200910260830.25168.jhb@freebsd.org>
Message-ID: <20091026185459.U91695@maildrop.int.zabbadoz.net>
References: <20091025134226.Q91695@maildrop.int.zabbadoz.net>
	<200910260830.25168.jhb@freebsd.org>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-arch@freebsd.org
Subject: Re: src/Makefile, universe, LINT, VIMAGE, ..
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Oct 2009 19:25:04 -0000

On Mon, 26 Oct 2009, John Baldwin wrote:

Hi,

>> @@ -345,3 +333,18 @@
>>   	fi
>>   .endif
>>   .endif
>> +
>> +universe_kernels: universe_kernels_foo
>> +TARGET?=	${BUILD_ARCH}
>> +KERNCONFS!=	cd ${.CURDIR}/sys/${TARGET}/conf && \
>> +		find [A-Z0-9]*[A-Z0-9] -type f -maxdepth 0 \
>> +		! -name DEFAULTS ! -name NOTES
>> +KERNCONFS:=	${KERNCONFS}
>> +universe_kernels_foo:
>> +.for kernel in ${KERNCONFS}
>> +	@(cd ${.CURDIR} && env __MAKE_CONF=/dev/null \
>> +	    ${MAKE} ${JFLAG} buildkernel TARGET=${TARGET} KERNCONF=${kernel} \
>> +	    > _.${TARGET}.${kernel} 2>&1 || \
>> +	    (echo "${TARGET} ${kernel} kernel failed," \
>> +	    "check _.${TARGET}.${kernel} for details"| ${MAKEFAIL}))
>> +.endfor
>
> Hmm, I'm not sure why you need a universe_kernels_foo target that
> universe_kernels depends on?

This is all about make and the variables after a target and within a
target. Whatever else I tried: make complained.  If you know the
rightbetter solution that works I'll be happy to simplify this and
update the patch.

It shouldn't be named _foo though;)


> Also, I would probably prefer to have
> universe_kernels come after universe_$target and before universe_epilogue.

I think that should be possible to sneak it in after the the .endfor.


>> Index: sys/conf/makeLINT.mk
>> ===================================================================
>> --- sys/conf/makeLINT.mk	(revision 198467)
>> +++ sys/conf/makeLINT.mk	(working copy)
>> @@ -5,7 +5,15 @@
>>
>>   clean:
>>   	rm -f LINT
>> +.if ${TARGET} == "amd64" || ${TARGET} == "i386"
>> +	rm -f LINT=VIMAGE
>> +.endif
>
> s/=/-/

Yeah, everyone notics that one; it should be fixed in the patch at the
URL originally referenced.

> BTW, I'm not sure why you would only enable VIMAGE for these two archs rather
> than doing it for all archs that have a LINT?

Because it'll usually simply not make any sense to build a VIMAGE
kernel for embedded platforms like arm, ...  Also make universe time
increases significantly with any platform; indeed amd64 is the worst
now (again).  We can talk about the proper set and I had thought of
sparc64 as well.  Obviously just building it everywhere simplifies
things.

/bz

-- 
Bjoern A. Zeeb         It will not break if you know what you are doing.