From owner-svn-src-all@freebsd.org  Fri Jan 11 18:36:20 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 092B1149821F;
 Fri, 11 Jan 2019 18:36:20 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5B1EE77B54;
 Fri, 11 Jan 2019 18:36:19 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x0BIaGNI022427;
 Fri, 11 Jan 2019 10:36:16 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x0BIaGVJ022426;
 Fri, 11 Jan 2019 10:36:16 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201901111836.x0BIaGVJ022426@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth
 usr.sbin/bluetooth/bluetooth-config
In-Reply-To: <CANCZdfp7hB9V90niJd-_h1M+9EaajaNNTUdezBKemJE+S9eMeQ@mail.gmail.com>
To: Warner Losh <imp@bsdimp.com>
Date: Fri, 11 Jan 2019 10:36:16 -0800 (PST)
CC: "Rodney W. Grimes" <rgrimes@freebsd.org>, Lars Engels <lme@freebsd.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 5B1EE77B54
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.96 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.999,0];
 NEURAL_HAM_SHORT(-0.96)[-0.962,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 18:36:20 -0000

[ Charset UTF-8 unsupported, converting... ]
> On Fri, Jan 11, 2019 at 10:10 AM Rodney W. Grimes <
> freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
> 
> > > On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote:
> > > > The style of this .sh does not match the normal style of
> > > > such things in base, especially with respect to long lines
> > > > and indentation.
> > >
> > > Do we have a style guide for shell scripts in base? How should
> > > indentation look like?
> >
> > Not that I can locate, but I can state that almost all
> > of the base code uses tab indenting and limited to 80
> > column widths, independent of c, sh, make, etc.
> >
> 
> We have a style.Makefile, style, style.mdoc and style.lua man pages. Maybe
> it's time for style.sh, eh?

Yes please!

-- 
Rod Grimes                                                 rgrimes@freebsd.org