From owner-svn-src-all@freebsd.org Wed Dec 20 02:55:37 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32C2DE8DA08; Wed, 20 Dec 2017 02:55:37 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D96D47858C; Wed, 20 Dec 2017 02:55:36 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id vBK2tXEY023725; Tue, 19 Dec 2017 18:55:33 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id vBK2tWT0023724; Tue, 19 Dec 2017 18:55:32 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201712200255.vBK2tWT0023724@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r327005 - in head: sbin/ipfw sys/sys usr.sbin/watch In-Reply-To: <5FDA0E4A-C1A9-4283-B80D-2C13FAF75FF9@FreeBSD.org> To: Pedro Giffuni Date: Tue, 19 Dec 2017 18:55:32 -0800 (PST) CC: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 02:55:37 -0000 > > > > On Dec 19, 2017, at 19:15, Rodney W. Grimes wrote: > > > >> Author: pfg > >> Date: Tue Dec 19 22:40:16 2017 > >> New Revision: 327005 > >> URL: https://svnweb.freebsd.org/changeset/base/327005 > >> > >> Log: > >> SPDX: These are fundamentally BSD-2-Clause. > >> > >> They just omit the introductory line and numbering. > > > > I again must assert that it would be better to not apply an SPDX than to > > apply one that is not an exact match for the license. > > > > > > Not being a lawyer, I would normally agree, however: This isnt about any legal issue. > 1) SPDX IDs are only advisory: we always keep the exact license text, which is what has legal value. And we should do our best to provide the most accurate advisory we can, and we know that this is not a direct copy of the BSD 2 clause, so making advice that it is, IMHO, would be poor advice. > 2) The license is detected by license scanners as BSD and it has two clauses so the description fits. And a human reading it sees it reads like a 2 clause but does not match a 2 clause exactly so how do I trust any of this SPDX stuff as being done with some ration of sanity. > FWIW, according to SPDX lawyers, the numbering is not relevant and it would appear to me that the phrase: > "Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:? doesn?t add any information to the two clauses, which read: Again, not a legal issue, an issue of this is not an exact BSD-2-Clause so I do not believe that we should tag it as such. Basically if we are doing this "close enough" thing it means the SPDX tags are actually pretty useless for anyone trying to do a legal evaluation cause they are just going have to completly redo what was done in adding the SPDX tags, and if that is the case we should seriously consider just what value do these have in the tree? > Redistributions of source code must ? > Redistributions in binary form must ... > > Pedro. > > > > >> Modified: > >> head/sbin/ipfw/altq.c > >> head/sbin/ipfw/dummynet.c > >> head/sbin/ipfw/ipfw2.c > >> head/sbin/ipfw/ipfw2.h > >> head/sbin/ipfw/ipv6.c > >> head/sbin/ipfw/main.c > >> head/sbin/ipfw/nat.c > >> head/sys/sys/msg.h > >> head/sys/sys/snoop.h > >> head/usr.sbin/watch/watch.c > > ... > > > > -- > > Rod Grimes rgrimes@freebsd.org > -- Rod Grimes rgrimes@freebsd.org