From owner-svn-ports-all@freebsd.org  Sun Jan 14 16:45:52 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7278BE79BE6;
 Sun, 14 Jan 2018 16:45:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 513BD82FFC;
 Sun, 14 Jan 2018 16:45:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id A2A51D4EF; Sun, 14 Jan 2018 16:45:51 +0000 (UTC)
Date: Sun, 14 Jan 2018 16:45:51 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Muhammad Moinur Rahman <bofh@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r458926 - head/java/java-checkstyle
Message-ID: <20180114164551.GA85642@FreeBSD.org>
References: <201801131125.w0DBPeqW003703@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201801131125.w0DBPeqW003703@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Jan 2018 16:45:52 -0000

On Sat, Jan 13, 2018 at 11:25:40AM +0000, Muhammad Moinur Rahman wrote:
> New Revision: 458926
> URL: https://svnweb.freebsd.org/changeset/ports/458926
> 
> Log:
>   java/java-checkstyle: Update version 7.6=>8.7
>   
>   - Pet PORTLINT
> 
> Added:
>   head/java/java-checkstyle/pkg-plist   (contents, props changed)
> 
> Modified: head/java/java-checkstyle/Makefile
> ...
> @@ -21,8 +21,6 @@ WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
>  
>  JAR_FILE=	${PORTNAME}-${PORTVERSION}-all.jar
>  
> -PLIST_FILES=	bin/${PORTNAME} \
> -		%%JAVAJARDIR%%/${PORTNAME}.jar
> 
> Added: head/java/java-checkstyle/pkg-plist
> ...
> @@ -0,0 +1,2 @@
> +bin/checkstyle
> +%%JAVAJARDIR%%/checkstyle.jar

I don't get it: we typically use PLIST_FILES for short PLISTs, why not
simply fix (expand) %%JAVAJARDIR%% and retain PLIST_FILES instead of
creating two-line pkg-plist?

./danfe