From owner-freebsd-bugs@FreeBSD.ORG Sun May 25 06:30:01 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4005EDDE for ; Sun, 25 May 2014 06:30:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1CA35227B for ; Sun, 25 May 2014 06:30:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s4P6U0HO053909 for ; Sun, 25 May 2014 06:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s4P6U0GP053908; Sun, 25 May 2014 06:30:00 GMT (envelope-from gnats) Resent-Date: Sun, 25 May 2014 06:30:00 GMT Resent-Message-Id: <201405250630.s4P6U0GP053908@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Trevor Roydhouse Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7B652DB2 for ; Sun, 25 May 2014 06:24:02 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 68D4A2261 for ; Sun, 25 May 2014 06:24:02 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s4P6O2eb099416 for ; Sun, 25 May 2014 06:24:02 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s4P6O2uW099413; Sun, 25 May 2014 06:24:02 GMT (envelope-from nobody) Message-Id: <201405250624.s4P6O2uW099413@cgiserv.freebsd.org> Date: Sun, 25 May 2014 06:24:02 GMT From: Trevor Roydhouse To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/190195: Missing asmc support for Macmini 3,1 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 May 2014 06:30:01 -0000 >Number: 190195 >Category: kern >Synopsis: Missing asmc support for Macmini 3,1 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 25 06:30:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Trevor Roydhouse >Release: 9.3-PRERELEASE >Organization: >Environment: FreeBSD shadow.sentry.org 9.3-PRERELEASE FreeBSD 9.3-PRERELEASE #12 r266632: Sun May 25 13:32:10 EST 2014 root@shadow.sentry.org:/usr/obj/usr/src/sys/MACMINI i386 >Description: The asmc module lacks details for the Macmini 3,1 hardware version. >How-To-Repeat: kldload supplied asmc.ko >Fix: See attached patches for asmc.c and asmcvar.h which have been running successfully on my system since FreeBSD 9.1-STABLE. Patch attached with submission follows: asmc.c 208a209,217 > /* The Mac Mini 3,1 has no SMS */ > { > "Macmini3,1", "Apple SMC Mac Mini 3,1", > NULL, NULL, NULL, > ASMC_FAN_FUNCS, > NULL, NULL, NULL, > ASMC_MM31_TEMPS, ASMC_MM31_TEMPNAMES, ASMC_MM31_TEMPDESCS > }, > asmcvar.h 182a183,201 > #define ASMC_MM31_TEMPS { "TC0D", "TC0H", \ > "TC0P", "TH0P", \ > "TN0D", "TN0P", \ > "TW0P", NULL } > > #define ASMC_MM31_TEMPNAMES { "cpu0_die", "cpu0_heatsink", \ > "cpu0_proximity", "hdd_bay", \ > "northbridge_die", \ > "northbridge_proximity", \ > "wireless_module", } > > #define ASMC_MM31_TEMPDESCS { "CPU0 Die Core Temperature", \ > "CPU0 Heatsink Temperature", \ > "CPU0 Proximity Temperature", \ > "HDD Bay Temperature", \ > "Northbridge Die Core Temperature", \ > "Northbridge Proximity Temperature", \ > "Wireless Module Temperature", } > >Release-Note: >Audit-Trail: >Unformatted: