From nobody Mon Jan 22 21:36:34 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TJk8H22Vqz58GPL; Mon, 22 Jan 2024 21:37:19 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TJk8H1X8qz4Qbh; Mon, 22 Jan 2024 21:37:19 +0000 (UTC) (envelope-from hrs@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705959439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pCR1I75fBvghd/X468Th69eUUM9DKETtZUujWWhYsuE=; b=jaDyTdlemKiZA4n4DKwmxBthmOrijjx4YaoYHUGqdEfu57Wi/Hgk0YEArpxD6obY4+VGwj 5vKh6XLxwFrTL59Ic/mxef1kPJn8E9wBaURQPx4p6nvuAgJln5OXdh+O52S0ZxC7n3XITT jLd3pOdvQ+e96Maxdol+/IigHhRYT8tNMbxp4tu5gZ9D0Lb/NW6AVoXe2iQ4csqKcTR2Ud Myln1lSG7rSiKDnCfDfLegr0EO9W+TSaRo//fU5zBXVQz80MKcnmyVHNwwxfD2tK0ut2vv cSH3S2ug2nrysDt2UJ+G/7GOUxTfIs+HG3rvWCO6RNHhI2wjEFmzPNGqFNJu2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705959439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pCR1I75fBvghd/X468Th69eUUM9DKETtZUujWWhYsuE=; b=Yv+G4gKaK4vBhyH29wG8VZPNCemu4ZPN2iLOCcq1vTnv93BEI1cajcoOwprloEjMq0Y78W jLrTbndHvEmqopaAlkZN5LkyETdffOXY+9a5d4EF0SmM7eg8d1soUg9kUU9rIcT9tm9Vtd FBe1D54u32FVdhzv9pO8+P49T2i81Q8DE9nBBAdwUf1VINBfxn64A/onqNzhQYU7qdWma9 c/7S9+4rrPVhQc6TY9MBHFFUC/r4sD2m3uAQEfLFX/Fh9PYnSU+O88PdWh24nK6VLgwhqi zbshsHEVdNMKOP8KJiLhrd1GQhscV5oONxcFlDe0BIL0+49Dm6xxeo11SAwRTA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705959439; a=rsa-sha256; cv=none; b=LWqYUZO33CNPkJtnKSWC9GYeX0vTWvoINXCMC1C/WkxYxNKJkVfvbMwimRDDe9zznDgFTo YHv5DxLNgZ/mKJf9M8QqquYC3qfo7F4sa8BojPKC3O0CLGQpYtkPobnRU9VOdnMmcAEQ8p yQJ7k7xUv3VgCSuLsPoLKse2BhAgrc8XvLF9TKYQQGSF5u8aK0DnAXzZhGOY4l+FdZ4GKn 4vjlZWqKYRHv/2GEHlDEs2EPu2A+S5lkQJzzZTOBFnRiavyY0WutzVloPX3zM4+QiObkZQ x37fjrBuJ9UNhudnmkglT48zOcfE4rdsLkCjQqU4C5I60to0EFoEIymEv27D2Q== Received: from localhost (unknown [IPv6:2400:4051:a743:3c00:5a9c:fcff:fe10:ffc2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: hrs) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TJk8G00Hbz11gZ; Mon, 22 Jan 2024 21:37:17 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Date: Tue, 23 Jan 2024 06:36:34 +0900 (JST) Message-Id: <20240123.063634.1428580388567496859.hrs@FreeBSD.org> To: bofh@freebsd.org Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 9a5a5a037897 - main - japanese/kterm: Sanitize MANPREFIX From: Hiroki Sato In-Reply-To: <372CB45E-1608-41D9-B43F-8D2BE834C68E@freebsd.org> References: <202401222027.40MKRVaH012805@gitrepo.freebsd.org> <20240123.060027.1610312468979447172.hrs@FreeBSD.org> <372CB45E-1608-41D9-B43F-8D2BE834C68E@freebsd.org> X-Old-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-PGPkey-fingerprint: 6C0D 2353 27CF 80C7 901E FDD2 DBB0 7DC6 6F1F 737F X-Mailer: Mew version 6.8 on Emacs 28.2 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha512; boundary="--Security_Multipart(Tue_Jan_23_06_36_34_2024_771)--" Content-Transfer-Encoding: 7bit ----Security_Multipart(Tue_Jan_23_06_36_34_2024_771)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Moin Rahman wrote in <372CB45E-1608-41D9-B43F-8D2BE834C68E@freebsd.org>: bo> bo> bo> > On Jan 22, 2024, at 10:00 PM, Hiroki Sato wrote: bo> > bo> > Muhammad Moinur Rahman wrote bo> > in <202401222027.40MKRVaH012805@gitrepo.freebsd.org>: bo> > bo> > bo> The branch main has been updated by bofh: bo> > bo> bo> > bo> URL: https://cgit.FreeBSD.org/ports/commit/?id=9a5a5a0378972be4f6b9d4d4c67c68baaebb1daa bo> > bo> bo> > bo> commit 9a5a5a0378972be4f6b9d4d4c67c68baaebb1daa bo> > bo> Author: Muhammad Moinur Rahman bo> > bo> AuthorDate: 2024-01-22 19:37:27 +0000 bo> > bo> Commit: Muhammad Moinur Rahman bo> > bo> CommitDate: 2024-01-22 20:26:42 +0000 bo> > bo> bo> > bo> japanese/kterm: Sanitize MANPREFIX bo> > bo> bo> > bo> Approved by: portmgr (blanket) bo> > bo> > ... bo> > bo> > bo> -man/ja.UTF-8/man1/kterm.1.gz bo> > bo> -man/man1/kterm.1.gz bo> > bo> +share/man/ja/man1/kterm.1.gz bo> > bo> +share/man/man1/kterm.1.gz bo> > bo> > Why does ja.UTF-8 need to be replaced with ja? The man(1) utility bo> > searches man/ and man/, not bo> > man/. bo> > bo> > -- Hiroki bo> bo> That's only applicable for base. Apart from that and ${PREFIX}/man bo> and ${PREFIX}/share/man everything has to be added to the MANPATH. You mean ${PREFIX}/share/man/ja needs to be added to MANPATH manually? ja.UTF-8 just works even for /usr/local by default as far as I can check. I got the following when entering "man -d kterm" and there is /usr/local/share/man/ja.UTF-8 and LANG=ja_JP.UTF-8: -- Using architecture: amd64:amd64 -- Using pager: less -- Searching PATH for man directories -- Adding /usr/share/man to manpath -- Adding /usr/local/share/man to manpath -- Adding /usr/local/man to manpath -- Adding default manpath entries -- Adding /usr/share/openssl/man to manpath -- Parsing config file: /usr/local/etc/man.d/perl5.conf -- Adding /usr/local/lib/perl5/site_perl/man to manpath -- Adding /usr/local/lib/perl5/5.36/perl/man to manpath -- Using manual path: /usr/share/man:/usr/local/share/man:/usr/local/man:/usr/share/openssl/man:/usr/local/lib/perl5/site_perl/man:/usr/local/lib/perl5/5.36/perl/man -- Using manual sections: 1:8:2:3:3lua:n:4:5:6:7:9:l -- Using locale paths: ja_JP.UTF-8:ja.UTF-8:en.UTF-8:. -- Using standard page width -- Searching for "kterm" -- Found manpage "/usr/local/share/man/ja.UTF-8/man1/kterm.1.gz" -- Skipping catpage: not found or old -- Command: /usr/bin/gzcat "/usr/local/share/man/ja.UTF-8/man1/kterm.1.gz" | mandoc | less And the following when there is /usr/local/share/man/ja and LANG=ja_JP.UTF-8: -- Using architecture: amd64:amd64 -- Using pager: less -- Searching PATH for man directories -- Adding /usr/share/man to manpath -- Adding /usr/local/share/man to manpath -- Adding /usr/local/man to manpath -- Adding default manpath entries -- Adding /usr/share/openssl/man to manpath -- Parsing config file: /usr/local/etc/man.d/perl5.conf -- Adding /usr/local/lib/perl5/site_perl/man to manpath -- Adding /usr/local/lib/perl5/5.36/perl/man to manpath -- Using manual path: /usr/share/man:/usr/local/share/man:/usr/local/man:/usr/share/openssl/man:/usr/local/lib/perl5/site_perl/man:/usr/local/lib/perl5/5.36/perl/man -- Using manual sections: 1:8:2:3:3lua:n:4:5:6:7:9:l -- Using locale paths: ja_JP.UTF-8:ja.UTF-8:en.UTF-8:. -- Using standard page width -- Searching for "kterm" -- Found manpage "/usr/local/share/man/man1/kterm.1.gz" -- Skipping catpage: not found or old -- Command: /usr/bin/gzcat "/usr/local/share/man/man1/kterm.1.gz" | mandoc | less This is the reason why I changed the pathname from ja to ja.UTF-8 in the previous commit. Am I missing something? -- Hiroki ----Security_Multipart(Tue_Jan_23_06_36_34_2024_771)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iMoEABMKAC4WIQRsDSNTJ8+Ax5Ae/dLbsH3Gbx9zfwUCZa7f4hAcaHJzQGZyZWVi c2Qub3JnAAoJENuwfcZvH3N/CCsCCQGd70sLiDt9eYxmzA9feZGjtNKJbwvwwzp+ hfrxzTatHugWeIJHJZiL2ZBY6sk29JIl4q1HglMIbG5CGlrWcFNLDAIJAWAdiZEE XNjW1YhSu3qL34pbrAWAcOq9dvKOH3ewaE98brQeKMNISnE3K5aJ7Una6+aIyLWk sbTI+SxglnK4KWEN =2g9g -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Jan_23_06_36_34_2024_771)----