From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 20:46:51 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C57A4F01 for ; Wed, 17 Jun 2015 20:46:51 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FDDD927 for ; Wed, 17 Jun 2015 20:46:51 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by wicnd19 with SMTP id nd19so3549221wic.1 for ; Wed, 17 Jun 2015 13:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=sHyBBzkciq9Y7Xi0uurSilNVIvXUE6xBN25wz/gIUC0=; b=gsuo/LUXWf9FrAYhN92Nc22zI6eyxVAQMc76fBJo34KdmNDTjt1BiLYQ0KOTVzNLT2 BLuKgRdHKb/QKlfXM9jxJNRO4Mw0albQgdn+ORMLBy9vSVws0fXaYa+OeBJtYYjh4eYl xIzZZUpXbf26cHfI19tS67PpgCGtSfrCFf73eMnbvbNsBZNMRkZsgEG4I8UpJg+wGT9K ARLWvBZ5TizFU6JB4RFAMKvJ9pmcV9wELuc52k5Yn2bANmVgrb1VzW7uCSfdKmQbyGVN x1i90Z/KBmvh0fvgoY0tIhXfjiIdOE9J65B0ZOoOcyDC2yOENrIsBR132/WX3HOMTPQ7 8mkw== MIME-Version: 1.0 X-Received: by 10.180.75.8 with SMTP id y8mr21430535wiv.31.1434574009785; Wed, 17 Jun 2015 13:46:49 -0700 (PDT) Received: by 10.194.248.163 with HTTP; Wed, 17 Jun 2015 13:46:49 -0700 (PDT) In-Reply-To: References: Date: Wed, 17 Jun 2015 13:46:49 -0700 Message-ID: Subject: Re: Reg Intel Fortville IXL driver on 11-CURRENT From: Jack Vogel To: Ryan Stone Cc: Lakshmi Narasimhan Sundararajan , freebsd-net , "Kloss, Joe" , "Pokala, Ravi" , "Tallam, Sreen" , "Lewis, Fred" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 20:46:52 -0000 As Ryan said, its there to keep queues marked as "hung" from getting more work scheduled on them. I really don't know what to make of it if commenting it out is somehow improving things :) I would suggest more careful analysis of what is going wrong before committing anything like deleting this. Jack On Wed, Jun 17, 2015 at 12:17 PM, Ryan Stone wrote: > On Wed, Jun 17, 2015 at 7:00 AM, Lakshmi Narasimhan Sundararajan < > lakshmi.n@msystechnologies.com> wrote: > > > [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ diff -c5pt > ixl_txrx.c > > ixl_txrx.c.mod > > *** ixl_txrx.c Fri Jun 12 06:56:51 2015 > > --- ixl_txrx.c.mod Fri Jun 12 06:56:33 2015 > > *************** ixl_mq_start(struct ifnet *ifp, struct m > > *** 96,112 **** > > --- 96,115 ---- > > } else > > #endif > > i = m->m_pkthdr.flowid % vsi->num_queues; > > } else > > i = curcpu % vsi->num_queues; > > + > > + #if 0 > > /* > > ** This may not be perfect, but until something > > ** better comes along it will keep from scheduling > > ** on stalled queues. > > */ > > if (((1 << i) & vsi->active_queues) == 0) > > i = ffsl(vsi->active_queues); > > + #endif > > > > que = &vsi->queues[i]; > > txr = &que->txr; > > > > err = drbr_enqueue(ifp, txr->br, m); > > [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ > > > > My understanding is that this code is intended to be triggered as a last > resort. If that code is firing regularly then the driver is not correctly > tracking which queues are alive in the "active_queues" bitmask. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >