From owner-svn-src-all@FreeBSD.ORG Thu Mar 29 15:43:08 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15EBC106566C; Thu, 29 Mar 2012 15:43:08 +0000 (UTC) (envelope-from jimharris@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 001A88FC17; Thu, 29 Mar 2012 15:43:07 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q2TFh7hv099463; Thu, 29 Mar 2012 15:43:07 GMT (envelope-from jimharris@svn.freebsd.org) Received: (from jimharris@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q2TFh7Ip099461; Thu, 29 Mar 2012 15:43:07 GMT (envelope-from jimharris@svn.freebsd.org) Message-Id: <201203291543.q2TFh7Ip099461@svn.freebsd.org> From: Jim Harris Date: Thu, 29 Mar 2012 15:43:07 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r233663 - head/sys/dev/isci/scil X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2012 15:43:08 -0000 Author: jimharris Date: Thu Mar 29 15:43:07 2012 New Revision: 233663 URL: http://svn.freebsd.org/changeset/base/233663 Log: Fix bug where isci(4) would report only 15 bytes of returned data on a READ_CAP_16 command to a SATA target. Sponsored by: Intel Reviewed by: sbruno Approved by: sbruno MFC after: 3 days Modified: head/sys/dev/isci/scil/sati_read_capacity.c Modified: head/sys/dev/isci/scil/sati_read_capacity.c ============================================================================== --- head/sys/dev/isci/scil/sati_read_capacity.c Thu Mar 29 15:33:44 2012 (r233662) +++ head/sys/dev/isci/scil/sati_read_capacity.c Thu Mar 29 15:43:07 2012 (r233663) @@ -308,6 +308,10 @@ void sati_read_capacity_16_translate_dat sati_set_data_byte(sequence, scsi_io, 10, (U8)((sector_size >> 8) & 0xFF)); sati_set_data_byte(sequence, scsi_io, 11, (U8)(sector_size & 0xFF)); + //Explicitly set byte 12 to 0. SATI requires that all bytes in the data + //response be explicitly set to some value. + sati_set_data_byte(sequence, scsi_io, 12, 0); + //Check Bit 13 of ATA_IDENTIFY_DEVICE_DATA physical_logical_sector_info //(Word 106) is enabled physical_per_logical_enable_bit = (identify_device_data->physical_logical_sector_info