From owner-freebsd-current@FreeBSD.ORG Sun Nov 28 18:14:43 2010 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5253C106567A; Sun, 28 Nov 2010 18:14:43 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id B5EEC8FC16; Sun, 28 Nov 2010 18:14:42 +0000 (UTC) Received: by wyf19 with SMTP id 19so3591091wyf.13 for ; Sun, 28 Nov 2010 10:14:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=KZfU1UJxddhb4e/GQClZh2D77/q24KJ/K0I4wMqKkZ0=; b=gYsONuvwt/rB5DIrtT0tyuJFywreZLcypyETqVXfEkHyQ37Kusd9yL5J0XOzfWfW6d Sw0xCWpomZFDo48c42XyxvdKaXLH4+H/wWFMhf5MMgQiF/MPA/ucKElWvCTtzFSy3kKI hATimcqD374IHomJ4pjqtdr+3wC24eBIagxKQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=HFqTiNZIoy39MrnjnjYuORQcNZsr0yF7vPi4TDcC0N3ojDFcfK0t+OjoPop8lNSc5R EGS4z4U/zu1Q6HUjkm3aoWjjCaOoYLEHowmBSANIWMaLJK/PM7isBjGadvz4bzXUEXuM EzIIqaHLxnRCz0ZHHtq1/s7cxCc/vb4mv3wbg= MIME-Version: 1.0 Received: by 10.216.51.8 with SMTP id a8mr1272678wec.62.1290968080731; Sun, 28 Nov 2010 10:14:40 -0800 (PST) Received: by 10.216.234.82 with HTTP; Sun, 28 Nov 2010 10:14:40 -0800 (PST) In-Reply-To: <20101125234527.GO92881@weongyo> References: <20101125234527.GO92881@weongyo> Date: Sun, 28 Nov 2010 18:14:40 +0000 Message-ID: From: Paul B Mahol To: Weongyo Jeong , current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Cc: Subject: Re: [CFR] a small change of ifconfig(8) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Nov 2010 18:14:43 -0000 On 11/25/10, Weongyo Jeong wrote: > Hello all, > > I'm sending this email to check whether my approach is reasonable that I > added 2 line into ifconfig(8) to skip IFT_USB interfaces as follows: > > + if (sdl != NULL && sdl->sdl_type == IFT_USB) > + continue; > > And as additionally I added two changes of USB pf to call if_up(ifp) / > if_down(ifp) explicitly to UP usbus interfaces though normally it always > should be called through user ioctl calls. > > The reason why I make this patch is that I encountered a side-effect > output from ifconfig(8) after USB packet filter is committed. Yes usbus > interfaces are printed. > > Please give me some hints whether the patch is reasonable. If it's > reasonable, is there other tools which I should make patches? Currently ifconfig will with special rc.conf configuration "hang" after boot making multiuser mode impossible to happen. Perhaps ifconfig tries to do something fancy with usbus interfaces.