From owner-cvs-all Sat Jul 28 18:36: 3 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [206.40.252.115]) by hub.freebsd.org (Postfix) with ESMTP id AA85737B403; Sat, 28 Jul 2001 18:35:54 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.4/8.11.1) id f6T1ZrJ06557; Sat, 28 Jul 2001 18:35:53 -0700 (PDT) (envelope-from obrien) Date: Sat, 28 Jul 2001 18:35:53 -0700 From: "David O'Brien" To: Greg Lehey Cc: Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Committer relations (was: cvs commit: src/usr.sbin/pkg_install/add main.c src/usr.sbin/pkg_install/lib str.c) Message-ID: <20010728183553.A6469@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200107280444.f6S4iAu46223@freefall.freebsd.org> <20010727222750.A60313@xor.obsecurity.org> <20010728110330.B11239@dragon.nuxi.com> <20010729100535.B68202@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010729100535.B68202@wantadilla.lemis.com>; from grog@FreeBSD.org on Sun, Jul 29, 2001 at 10:05:35AM +0930 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jul 29, 2001 at 10:05:35AM +0930, Greg Lehey wrote: > On Saturday, 28 July 2001 at 11:03:30 -0700, David O'Brien wrote: > > On Fri, Jul 27, 2001 at 10:27:51PM -0700, Kris Kennaway wrote: > >> > >> I wasn't wearing my security officer hat in requesting the backout, I > >> was wearing my "Joe Ordinary Committer" hat who had his face slapped > > > > How was I slapping your face? > > David, you say that you changed Kris' code and had it reviewed by > several people. Why was Kris not one of those people? If people want to take this position. Why did Kris not send me rev 1.38 of usr.sbin/pkg_install/add/main.c for review? He totally rewrote my code with that commit? If anything, I have cart blanch over changes in getpackagesite() as I wrote most of that function. I find this position funny. So what will be the amount of time that must elapse after a commit before I can change a piece of code w/o passing the commit past who ``cvs ann'' says is the author of the code? Are you suggesting that every commit now needs to be reviewed? You know that every line of code has an author. > > I saw code that could be improved a little. So I did. > > But you didn't tell Kris about it. One of the things about working in Why aren't you addressing the great injustice done to me by Kris in changing my code as he did??? -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message