Date: Thu, 25 Aug 2016 12:40:44 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Chris Rees <crees@physics.org>, Chris Rees <crees@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420830 - in head/databases: . neo4j neo4j/files Message-ID: <E517BD68BFD4F4C37851CDEA@ogg.in.absolight.net> In-Reply-To: <6C64CE8A-06BF-48F8-A7B0-B4F7D9552061@physics.org> References: <201608250219.u7P2JFVf030918@repo.freebsd.org> <117832A4D3327FBB22E27C1A@atuin.in.mat.cc> <6C64CE8A-06BF-48F8-A7B0-B4F7D9552061@physics.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========F7D0198D33207DC0A64D==========
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
+--On 25 ao=C3=BBt 2016 10:11:41 +0100 Chris Rees <crees@physics.org> =
wrote:
|=20
|=20
| On 25 August 2016 09:47:07 BST, Mathieu Arnold <mat@FreeBSD.org> wrote:
|>=20
|>=20
|> +--On 25 ao=C3=BBt 2016 02:19:15 +0000 Chris Rees <crees@FreeBSD.org> =
wrote:
|>| +post-patch:
|>| + ${REINPLACE_CMD} ${_SUB_LIST_TEMP} ${WRKSRC}/bin/neo4j-shared.sh \
|>| + ${WRKSRC}/conf/neo4j.conf
|>=20
|> _SUB_LIST_TEMP is an undocumented *internal* framework variable. It
|> should
|> *never* be used in a port's Makefile.
|> With the amount of things I'm rewriting, it may disapear any day, and I
|> will not hunt down the ports that use it where they should not.
|=20
| I must say I had a reservation about using it, although I think I've seen
| this done before. I think this should be exposed as ${SUB_SED_COMMAND}
| or something because it's useful.
|=20
| Is there a mechanism for having patchfiles as SUB_FILES?
No, it is a bad idea to use sed on patches because it makes running make
makepatch impossible.
It is why everyone uses sed in post-patch to replace the %%foo%% they put
in their patches.
To regenerate your patches, all you then have to do is:
make clean extract do-patch makepatch
(or if USES=3Ddos2unix)
make clean extract dos2unix do-patch makepatch
--=20
Mathieu Arnold
--==========F7D0198D33207DC0A64D==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJXvssuXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IMmgP/2lltPZxDqtkhBZkFT9aZr0O
g7lL+qUGYXYbI8JjuPDSOFcKNI8oVSXdh6Izyt6GnI5NIQzCR/YFfap/ArwsaqJS
UJeJSQwZL4LxK5Pn3eGsw1lKur/ImDDzVE3e9vJp2C9++zMG4tWV4X+ywHP9d/2Z
4QAY3jYZnrRqdpNA1tX3RKRZaUrugrTeCxoLw4xRo6kNpHPuQrPjnbiyf0n3ewf/
YZRlZfrqz6EXKRK0C7bpyzfSMsUz1HjAk22LvqJ2FPYG5RxirrlZ7jAI1RDk3gDI
gucVWGRZYGEks6hhYtP2Dk+nLerH7AnQbwDtsbu6HpeXQIWqo9P/Ok/y5Bg/SO66
1tov1UuqYf048IbSQ6KFmSTompwn1D0ynXhgXoDZ0MwCAvF57RCk75tgA7LS3gyN
BMQEa1xBv2KfmRP6ieRYezpkcQI0FORRRbHi80cJBBmGk1gJ/HtyMZ4ESK9VwFVG
AdRlpyXU90xbyicYLsReVrPp8F+sFkZ6M/LENHYlYse/xxZdzj98h8kImrNcixsI
sgZ0NvTitoqS40syc/HF7HQjOiBtisKgfzaLmEtBrQKlVlJroWBbvtP2wlSbMKcL
z9qv9pBD/nC1okqvgLjeA23J/bBD6/mAPQO8jmC1tEhYU4ELKNjaC99fvsSvrfJo
M22CdbYgJCxowkcWbwT+
=6AmQ
-----END PGP SIGNATURE-----
--==========F7D0198D33207DC0A64D==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E517BD68BFD4F4C37851CDEA>