Date: Fri, 17 Oct 2014 04:08:57 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: src-committers <src-committers@freebsd.org>, Ed Maste <emaste@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, "George V. Neville-Neil" <gnn@freebsd.org>, Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <olivier@cochard.me>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys Message-ID: <20141017000857.GH73266@FreeBSD.org> In-Reply-To: <86wq7zwq1w.fsf@nine.des.no> References: <201410101926.s9AJQRY1049602@svn.freebsd.org> <CA%2Bq%2BTcpt0zEbgu_LndZb4dzh=xykHvppeykuiG6P9cTJgDGeWw@mail.gmail.com> <20141015030455.GC73266@FreeBSD.org> <CAPyFy2CDSwLkTtPFj70tw2iuDam3rS4yFNri=pX0w7_58UYMoA@mail.gmail.com> <86wq81y9fz.fsf@nine.des.no> <20141016225955.GE73266@FreeBSD.org> <86wq7zwq1w.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 17, 2014 at 01:30:35AM +0200, Dag-Erling Smørgrav wrote: D> Gleb Smirnoff <glebius@FreeBSD.org> writes: D> > The function should also be documented in hash(9). D> D> It's not intended as a "general kernel hashing function". It is D> intended solely for pf. Why? If so, it should live in pf and not compiled uncoditionally into all kernels. Anyway, I don't see reason for doing it non-generic. P.S. Once I gathered 3 jenkins hash copy-n-pastes into one place, and we still got an extra copy in ofed. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141017000857.GH73266>