From owner-freebsd-bugs  Sun Mar  3 11:10: 6 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 831A637B405
	for <freebsd-bugs@hub.freebsd.org>; Sun,  3 Mar 2002 11:10:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g23JA1u35963;
	Sun, 3 Mar 2002 11:10:01 -0800 (PST)
	(envelope-from gnats)
Date: Sun, 3 Mar 2002 11:10:01 -0800 (PST)
Message-Id: <200203031910.g23JA1u35963@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Peter Pentchev <roam@ringlet.net>
Subject: Re: bin/35505: [PATCH] Feature enhancement for sed(1)
Reply-To: Peter Pentchev <roam@ringlet.net>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR bin/35505; it has been noted by GNATS.

From: Peter Pentchev <roam@ringlet.net>
To: "Matthew D.Fuller" <fullermd@over-yonder.net>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: bin/35505: [PATCH] Feature enhancement for sed(1)
Date: Sun, 3 Mar 2002 21:05:05 +0200

 On Sun, Mar 03, 2002 at 12:27:40AM -0600, Matthew D.Fuller wrote:
 >=20
 > >Number:         35505
 > >Category:       bin
 > >Synopsis:       [PATCH] Feature enhancement for sed(1)
 > >Originator:     Matthew D. Fuller
 [snip]
 > >Fix:
 [patch snipped]
 
 I think that something like the attached would befit style(9) more.
 Other than a few style nits, your patch looks great, and the functionality
 is something that I really do like :)
 
 Now let us see how this goes down with the src committers..
 
 G'luck,
 Peter
 
 --=20
 Peter Pentchev	roam@ringlet.net	roam@FreeBSD.org
 PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
 Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
 This sentence contradicts itself - or rather - well, no, actually it doesn'=
 t!
 
 Index: src/usr.bin/sed/Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /home/ncvs/src/usr.bin/sed/Makefile,v
 retrieving revision 1.4
 diff -u -r1.4 Makefile
 --- src/usr.bin/sed/Makefile	8 Feb 2002 23:07:35 -0000	1.4
 +++ src/usr.bin/sed/Makefile	3 Mar 2002 18:59:52 -0000
 @@ -4,5 +4,6 @@
  PROG=3D	sed
  SRCS=3D	compile.c main.c misc.c process.c
 =20
 +LINKS+=3D ${BINDIR}/sed ${BINDIR}/esed
 =20
  .include <bsd.prog.mk>
 Index: src/usr.bin/sed/main.c
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /home/ncvs/src/usr.bin/sed/main.c,v
 retrieving revision 1.14
 diff -u -r1.14 main.c
 --- src/usr.bin/sed/main.c	12 Dec 2001 23:20:16 -0000	1.14
 +++ src/usr.bin/sed/main.c	3 Mar 2002 19:01:05 -0000
 @@ -114,9 +114,17 @@
  	char *argv[];
  {
  	int c, fflag;
 -	char *temp_arg;
 +	char *progname, *temp_arg;
 =20
  	(void) setlocale(LC_ALL, "");
 +
 +	progname =3D strrchr(*argv, '/');
 +	if (progname !=3D NULL)
 +		progname++;
 +	else
 +		progname =3D *argv;
 +	if (*progname=3D=3D'e')
 +		rflags =3D REG_EXTENDED;
 =20
  	fflag =3D 0;
  	while ((c =3D getopt(argc, argv, "Eae:f:n")) !=3D -1)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message