From nobody Fri Nov 17 18:51:40 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SX5bd1FnPz51GZK; Fri, 17 Nov 2023 18:51:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SX5bd0NS3z3F4v; Fri, 17 Nov 2023 18:51:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700247101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gJ0uTqvDbTlIgpAW0K9GHRlTMUHQ2HNFFQlAx0uQb2c=; b=hqEnetPx5ZJXp9aohgjWKHBMMuuusTCEDE+fK6O+sXR32OpU/Y/oI1SVB/8nxQDp8VPhXo JQBVixte/YzCPFAQiVdKQ/kMBEdK5yaXWTe7o2CjvRMSJDyO76idCrPToSG470hv/cxK2u 7DTgp5TLZ7Qhso/QLQlatx8x5qFhUTpDEjDmyDhouWoOmJoXhmRF70WnW39S3kVBRcrey3 /c4w1m8RPLN8enlHGU1BqILECX9po2rYJmyVqoNfpwbOPp0Ohizr79OErgBpF8nySZoNzi lxo+y7Wuj9qqNHqeDYUdJmZ64fpxr+n5yzRI0QRL2LnmvGP3BDTqq0mS+i4pIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700247101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gJ0uTqvDbTlIgpAW0K9GHRlTMUHQ2HNFFQlAx0uQb2c=; b=v7yekcMI1H5BYDjlAd9dCsVnUZ+c7aQrlM4xKDzmQmmp3ApHdw7cV0J+cLDMHkt5oHKGRW MaIpkK4zV6X+7j3vzXwws6sc6b3IyTA8pFA+5XjalZba/gMPkT5+f0c0CvXp7p3SuzNsAu deJAhDsTDRRYNmHgFLPVcSZOE5Vy2jUIFgusydrcRbW8w3tJL9t5FmF99iMNyWS/Njs+7A Q9BuuU6Z8YtGZjzUWcc+DbMzRe6EQnffj0fOP+ZM5zCg9HVyXu+gAN7dHgyCMjkdljcIue 0v5uC5SRDaVH2gsXmRJ5IbR+3kVjnR7i3Bm0lWmz47zA150HhZH24CTqcZ/Avw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1700247101; a=rsa-sha256; cv=none; b=EsG/JcT6fDHCA/S6YMXuMAovSOMNqfUw7FQ2bQssfV2E3eiaFaIzah9kVPxCml2BFaa2lA mc/bPk/ANAP9C9zEQd/LuswEyv6rTcZ2ey6yVnw/MJ98L07tkVbDLxWnjjPOahXTKvFwtL cSYTy8/tpeSFK4b9y1eZI9L25XYa1V5Lj7XE0mZWbXcjb11QQiG4BAnPZKSUqOmSGhr1kh kyxGecUhrGUl7sit9hIDsAtRRumqfM/8Q7Tm+Cj5M3ON68Mft9JSbBrW3Fw2oY6p7y5QZ9 ZM3VKU01nRZ7iauIllsGKvaLTqts7euhp6TIYBKHfZgZgcRYOqNhEfCTgoymow== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SX5bc6bJMzv1R; Fri, 17 Nov 2023 18:51:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3AHIpeOS057645; Fri, 17 Nov 2023 18:51:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3AHIpe9m057642; Fri, 17 Nov 2023 18:51:40 GMT (envelope-from git) Date: Fri, 17 Nov 2023 18:51:40 GMT Message-Id: <202311171851.3AHIpe9m057642@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mike Karels Subject: git: 415c1c748d54 - main - khelp: suppress useless warning message on shutdown List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: karels X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 415c1c748d5492e41328fedf96b6bf3c9be94595 Auto-Submitted: auto-generated The branch main has been updated by karels: URL: https://cgit.FreeBSD.org/src/commit/?id=415c1c748d5492e41328fedf96b6bf3c9be94595 commit 415c1c748d5492e41328fedf96b6bf3c9be94595 Author: Mike Karels AuthorDate: 2023-11-17 18:51:18 +0000 Commit: Mike Karels CommitDate: 2023-11-17 18:51:18 +0000 khelp: suppress useless warning message on shutdown If a module (e.g. the ertt hhook for TCP) can't clean up at shutdown, there is nothing to be done about it. In the ertt case, cleanup is just shutting down a UMA zone, which doesn't need to be done. Suppress EBUSY warnings on shutdown. PR: 271677 Reviewed by: tuexen, imp Differential Revision: https://reviews.freebsd.org/D42650 --- sys/kern/kern_khelp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_khelp.c b/sys/kern/kern_khelp.c index 3d75da141b48..f8a6f3e749da 100644 --- a/sys/kern/kern_khelp.c +++ b/sys/kern/kern_khelp.c @@ -357,7 +357,7 @@ khelp_modevent(module_t mod, int event_type, void *data) } else if (error == ENOENT) /* Do nothing and allow unload if helper not in list. */ error = 0; - else if (error == EBUSY) + else if (error == EBUSY && event_type != MOD_SHUTDOWN) printf("Khelp module \"%s\" can't unload until its " "refcount drops from %d to 0.\n", kmd->name, kmd->helper->h_refcount);