From owner-svn-src-all@freebsd.org Fri Sep 18 20:10:19 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E8A13EE60B for ; Fri, 18 Sep 2020 20:10:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound5a.ore.mailhop.org (outbound5a.ore.mailhop.org [44.233.67.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BtQ1R040cz43Vy for ; Fri, 18 Sep 2020 20:10:18 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1600459817; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=YeI5a3D0dG4jgmJSCBRn4iaCILCw7QF4Hi9iHaHFINqEHkygR7pX1CqDbN3OPgC5eOabBuPBCPROC /uaXk/p14RArCXnqoZyyiLjPIPaH4FNyRO4/pPvg2ed598nQ4dRN38axqfwpbiBk4Lk9NnUolDGYyK HqD325tUk6WtUh4Ye8gIdkUiGDnHHomsqO6MemhrLTd7dwnUyG1lW57BINb533Q/Lv6S6Ufp3gPWtk EeWJt33LBS+ek05Rr7ln+NZalKnrya6S35ueih6dCal/5c27kT+0KvwvX6btB+EQrrubApuPgOOPl9 0suqGaXAGFcpTb9wvz8qalITBUA+fgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=8ITYyr0BCkwdLVa7hCXe1Sa42eI1xUHhRNf6ganYN8M=; b=Vw4VLqOMMDKE9PIyoNDA7GIPgwWH2Pg4znfhRVs/WJ1W7QV45TwINbud9ESRo7reUyWXQsrmwOG1J bz+Fyx+kpxthSDyXFBOI1N51E86H4/QDQyJDvn1JeLvEp8jSaOUT9DaTZgtnPowQgwCqj5UHyKzzqC je4on92Foo5X4nx56Pd+Ov8QbxjUvSkOH/KwcC4/hxX1LajQ5dGQP5dSNfamqu33awC511bImCTiei 8cEdE7mTOXg+H8OspNy6S2VP6Z5qZ/rn93jXIB3RRAU5FpGT1fmx6AZi1+nzPiUT/zA+Ti/9JAzKud armMIAdUf2RQlIx+/AsH9CsuPpwUPGA== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=8ITYyr0BCkwdLVa7hCXe1Sa42eI1xUHhRNf6ganYN8M=; b=VebIIDyWNPiIFoaiIheZsGYf6kLOKmT33SkjajFeihuW/+/AZakYsHnXGo66lKBgDg1ARw4o8tO19 k96A1LCnUkipGWt+BPdrPANLO0l46EOZjYVJmJXxWOWKnR6Anz3kIJfyvd1PmMIvLGFwlHfbNXc/Op svMBgwD61l43e8yy7ZBqpGYd+ZfkhmyYxkarb1+YSiPX74N4wOhaHGdA36pJhaPQUrcN4029ksdEIl TlLqOYVv99pu9vrAGevBL6bVDjKKJBZK93BL8mchOdyVlJgj66Gtbtjr3l/r5SUTtd6PcW2H0wLIdX abKc2wzHpYrPqey31HT75cOx8PUPz2w== X-MHO-RoutePath: aGlwcGll X-MHO-User: f67c6819-f9ea-11ea-8b38-614106969e8d X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id f67c6819-f9ea-11ea-8b38-614106969e8d; Fri, 18 Sep 2020 20:10:15 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 08IKAD8Y010822; Fri, 18 Sep 2020 14:10:14 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <3a0ce4f32721320bd04e400cfda05f2383d46220.camel@freebsd.org> Subject: Re: svn commit: r365889 - head/share/mk From: Ian Lepore To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, kan@freebsd.org Date: Fri, 18 Sep 2020 14:10:13 -0600 In-Reply-To: <20200918194400.GA36442@raichu> References: <202009181903.08IJ3YTM014958@repo.freebsd.org> <311b50c504a5dc1e54a1442aa4f759b14f263b67.camel@freebsd.org> <20200918194400.GA36442@raichu> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4BtQ1R040cz43Vy X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:16509, ipnet:44.224.0.0/11, country:US]; local_wl_from(0.00)[freebsd.org] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 20:10:19 -0000 On Fri, 2020-09-18 at 15:44 -0400, Mark Johnston wrote: > On Fri, Sep 18, 2020 at 01:27:23PM -0600, Ian Lepore wrote: > > On Fri, 2020-09-18 at 19:03 +0000, Mark Johnston wrote: > > > Author: markj > > > Date: Fri Sep 18 19:03:34 2020 > > > New Revision: 365889 > > > URL: https://svnweb.freebsd.org/changeset/base/365889 > > > > > > Log: > > > Install library symlinks atomically. > > > > > > As we do for shared library binaries, pass -S to install(1) when > > > installing symlinks. Doing so helps avoid transient failures when > > > libraries are being reinstalled, which seems to be the root cause > > > of > > > spurious libgcc_s.so link failures during CI builds. > > > > > > > Actually, I believe this will just paper over the real problem, which > > is the fact that we're building and installing the same library > > multiple times during early build steps. Nobody has yet been able to > > explain why we do that, and I haven't been able to figure out why by > > analyzing any differences in the generated files, but I'm not done > > trying. > > Sorry, this deserved more commentary in the commit log. > > Indeed, we install libgcc_s.so multiple times during buildworld. As far > as I can see, it's intentional insofar as libgcc_s.so is listed in > multiple library targets: it's in both _prereq_libs and _startup_libs in > Makefile.inc1. In particular, from scanning the log from a recent > instance of the failure, libgcc_s gets built once but installed multiple > times. > > Why that's the case, or whether it's still necessary, is not clear to > me. But adding -S seemed like a desirable change in general, so I went > forward with it. Yeah, it has been listed in both prereq and startup list since it was first added by kan@ in 2007 or so. I wonder if he remembers why (added to cc list)? -- Ian