From owner-svn-src-head@FreeBSD.ORG  Sun Oct 27 16:02:07 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 7A523348;
 Sun, 27 Oct 2013 16:02:07 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-qc0-x22b.google.com (mail-qc0-x22b.google.com
 [IPv6:2607:f8b0:400d:c01::22b])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 086532E8D;
 Sun, 27 Oct 2013 16:02:06 +0000 (UTC)
Received: by mail-qc0-f171.google.com with SMTP id i7so3339726qcq.30
 for <multiple recipients>; Sun, 27 Oct 2013 09:02:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=60xqyYTbP1ocjaoWXNhtnJjRc0gmb9ygJg1NZNPkee8=;
 b=b+Wr97g7WJ9Do01QApp1hklGDJDyPwW9ZJuMRRa93LSv6OgP/wdYjrgt0jnVtFQo/h
 y/7eiPd+qcKCejk05BaS8kWck+GuIApXP92cmy8XPvz5Ulj7G7e6LC7auk9FrYv0D80Z
 0KAqGTWGEUkTRjpoEf0ec+lv8FtsF6GkANEreJMV7SegQq12VGdbfadNYrIQgZHMiKBU
 Q18HV7iMkBuioybCeolqOAppy5WHi415zMVB7jFDZ3lJkmuITq6ipRT+mq/cNLnfyDDN
 cmugf5sk0s054Jc1ZTbaA+tQMZ98tKJHC9dlFFyBfeRjNSghKPKROp1ur6dHjX3CjBV5
 7MTQ==
MIME-Version: 1.0
X-Received: by 10.224.51.131 with SMTP id d3mr24815239qag.0.1382889726171;
 Sun, 27 Oct 2013 09:02:06 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.224.207.66 with HTTP; Sun, 27 Oct 2013 09:02:06 -0700 (PDT)
In-Reply-To: <20131027071909.GH52889@FreeBSD.org>
References: <201310261840.r9QIeH89083767@svn.freebsd.org>
 <CAJ-VmonmXgQUOFDw=ZHYXVbsNS54vUwCXt8JiZ=mKENvG85F9Q@mail.gmail.com>
 <20131027071909.GH52889@FreeBSD.org>
Date: Sun, 27 Oct 2013 09:02:06 -0700
X-Google-Sender-Auth: Il8p9HgCqMLJsGkrJgJVWRSHWSQ
Message-ID: <CAJ-VmomjjrxEJYzJ_V=_fPpy-1N8xkcDWnSakJpoREoSYc9SDg@mail.gmail.com>
Subject: Re: svn commit: r257184 - in head/sys/dev: mii usb/net xl
From: Adrian Chadd <adrian@freebsd.org>
To: Gleb Smirnoff <glebius@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Oct 2013 16:02:07 -0000

Cool.

Just make sure you check the odd ones like USB, where ejecting may
occur during or just before the callout runs, and the callout tries
accessing registers that aren't there.

Sure the previous was racy, but it may have been "not racy enough" to
cause most people to never see a panic.



-adrian


On 27 October 2013 00:19, Gleb Smirnoff <glebius@freebsd.org> wrote:
> On Sat, Oct 26, 2013 at 06:57:04PM -0700, Adrian Chadd wrote:
> A> hm, so none of the modified PHYs nor their consumers will get upset?
> A> Eg, if the NIC is down, is touching the PHY registers going to be a
> A> problem?
>
> The IFF_UP was always an administrative flag. I believe drivers initialize
> all their resources before being set an address with SIOCSIFADDR.
>
> If a driver doesn't, then the previous code still was racy.
>
> Anyway, I am going to handle any fallouts.
>
>
> --
> Totus tuus, Glebius.