From owner-svn-src-all@freebsd.org Sat Oct 31 20:33:38 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D20DD455ADC; Sat, 31 Oct 2020 20:33:38 +0000 (UTC) (envelope-from bdragon@imap.cc) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CNrVV3WB7z3gml; Sat, 31 Oct 2020 20:33:38 +0000 (UTC) (envelope-from bdragon@imap.cc) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BD2615C0078; Sat, 31 Oct 2020 16:33:37 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute5.internal (MEProxy); Sat, 31 Oct 2020 16:33:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imap.cc; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=eM9CJ8VIiSrtQ2sWD3YDd+X7JK0PvwE MEXkEY9LHBi0=; b=GadV1F/HWxikLzeb31EC5j7AsWnmu+hr3cULsgiKvXfO9IM HNDPEW702TTzm+IJWhBg5wFrcZZ0LlW6UyvC+yojQ/9jtYtzrwMHwJe+DHj4EY7F dTD4fOKo2bAL8yoC92jipP1a7s8/xgFNOs08p/s1Kw6C/oHkrXuMhfWpGoI0/5Qg sosMSOUVmxRd/z1z6DJHXlWI1FB5h6VMYtbUfxGQJOpPDPvV6Mr/zOFjf31m/dqv wObWo5M6dfHnDTH4Y+/NWrjofKhgqVdWr/AXIy0jBJcef+OCOP9mmUQPhIy7xMrH 0sqJz+p2yULKCakIr/Mp9y9XRE+EDG+ql63A9Pg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=eM9CJ8 VIiSrtQ2sWD3YDd+X7JK0PvwEMEXkEY9LHBi0=; b=JAcAn4fACoOukcoRcXqlDG yAuXbAX1OAbvaZlZyPLfoE/oItcxfLfuysC99cy+avBLZZ8qQoUqTtXIMis1ob3r GXLTsCjimTQ0T6KX34mrG/TZp5XqRQInZxdXXs7A7BdiJj9MwQS4ZfbeynFF0QAB Z5or2m09CnQ5qWayr6P5g9UfDhs0RNCns5RLAJooolS7Qm3eU5rbbDNuqDgeIXgI YVFjmYV6kjZHTdswyre08ifJkkjWp3Lsei7aamsp0LsqfFU1JrvyKm1Xjv8+oMjI ++q5QNT729ZG+a01EQ/dL7dhMMfTqVGY78zsuqNl6BhBTzu3BKPyw+hppPCVDHpQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleejgddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdluddtmdenucfjughrpefofgggkfgjfhffhffvufgtsehttdertder reejnecuhfhrohhmpedfuehrrghnughonhcuuegvrhhgrhgvnhdfuceosggurhgrghhonh esihhmrghprdgttgeqnecuggftrfgrthhtvghrnhepfeejgffgkeeitdeitdeuheevkeeh feejheetgedvgffhgffhvdfhvedvkeefhfdvnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepsggurhgrghhonhesihhmrghprdgttg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 45DA2C200A5; Sat, 31 Oct 2020 16:33:37 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-530-g8da6958-fm-20201021.003-g69105b13-v35 Mime-Version: 1.0 Message-Id: <540675c8-35bb-40a7-b947-73f31a72bff2@www.fastmail.com> In-Reply-To: References: <202010311907.09VJ7WcY036325@repo.freebsd.org> <7b9e157c-9b8e-4a0e-b3f6-38edbfebf005@www.fastmail.com> Date: Sat, 31 Oct 2020 15:33:17 -0500 From: "Brandon Bergren" To: "Brandon Bergren" , "Mateusz Guzik" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: =?UTF-8?Q?Re:_svn_commit:_r367229_-_in_head/sys/contrib/openzfs:_include?= =?UTF-8?Q?/sys/zstd_module/zstd?= Content-Type: text/plain X-Rspamd-Queue-Id: 4CNrVV3WB7z3gml X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2020 20:33:38 -0000 Maybe this is it?: Index: sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h =================================================================== --- sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (revision 367230) +++ sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (working copy) @@ -188,6 +188,8 @@ */ #undef atomic_add_64 #define atomic_add_64(ptr, val) *(ptr) += val +#undef atomic_sub_64 +#define atomic_sub_64(ptr, val) *(ptr) -= val #endif /* !_STANDALONE */ #endif /* !_OPENSOLARIS_SYS_ATOMIC_H_ */ Note that there is also another build failure in the tree at the moment. On Sat, Oct 31, 2020, at 3:25 PM, Brandon Bergren wrote: > Actually, looking at it again, it looks like the spl header is doing it > wrong and not providing a fallback for atomic_sub_64, it's just > defining it to atomic_subtract_64 and assuming that exists. > > On Sat, Oct 31, 2020, at 3:23 PM, Mateusz Guzik wrote: > > Yep, jenkins told me. Working on it. > > > > On 10/31/20, Brandon Bergren wrote: > > > This doesn't compile on platforms such as powerpc without pulling in the > > > opensolaris atomics header from the spl that does locking emulation of 64 > > > bit atomics, as platforms that don't have native 64 bit atomics do not > > > provide them in the system header. > -- Brandon Bergren bdragon@imap.cc