From owner-freebsd-arch@FreeBSD.ORG  Tue Jun  4 21:29:20 2013
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id BE54F904;
 Tue,  4 Jun 2013 21:29:20 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
 by mx1.freebsd.org (Postfix) with ESMTP id 730971CFD;
 Tue,  4 Jun 2013 21:29:20 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mx1.stack.nl (Postfix) with ESMTP id 026FF3592DD;
 Tue,  4 Jun 2013 23:29:17 +0200 (CEST)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id DE0BE28493; Tue,  4 Jun 2013 23:29:17 +0200 (CEST)
Date: Tue, 4 Jun 2013 23:29:17 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: aio_mlock(2) system call
Message-ID: <20130604212917.GA72412@stack.nl>
References: <20130603100618.GH67170@FreeBSD.org>
 <20130603161255.GM3047@kib.kiev.ua>
 <20130604113035.GV67170@glebius.int.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130604113035.GV67170@glebius.int.ru>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Konstantin Belousov <kostikbel@gmail.com>, arch@FreeBSD.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jun 2013 21:29:20 -0000

On Tue, Jun 04, 2013 at 03:30:35PM +0400, Gleb Smirnoff wrote:
>   Updated patch.

> [snip]
> Index: lib/libc/sys/Symbol.map
> ===================================================================
> --- lib/libc/sys/Symbol.map	(revision 251369)
> +++ lib/libc/sys/Symbol.map	(working copy)
> @@ -378,6 +378,7 @@ FBSD_1.2 {
>  };
>  
>  FBSD_1.3 {
> +	aio_mlock;
>  	accept4;
>  	bindat;
>  	cap_fcntls_get;

This should probably be in alphabetical order.

> Index: lib/libc/sys/aio_mlock.2
> ===================================================================
> --- lib/libc/sys/aio_mlock.2	(revision 0)
> +++ lib/libc/sys/aio_mlock.2	(working copy)
> [snip]
> +.Sh PORTABILITY
> +The
> +.Fn aio_mlock
> +system call is a
> +.Fx
> +extension, and shouldn't be used in portable code.

Man pages should not use contractions.

> [snip]
> Index: sys/sys/aio.h
> ===================================================================
> --- sys/sys/aio.h	(revision 251369)
> +++ sys/sys/aio.h	(working copy)
> @@ -38,6 +38,7 @@
>  #ifdef _KERNEL
>  #define	LIO_SYNC		0x3
>  #endif
> +#define	LIO_MLOCK		0x4

Is it intended that the new constant is available to userland, such as
for use in lio_listio(2)?

> [snip]

-- 
Jilles Tjoelker