From owner-svn-src-head@freebsd.org Thu Nov 29 16:27:46 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7EFAC1142EB6 for ; Thu, 29 Nov 2018 16:27:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EC68773905 for ; Thu, 29 Nov 2018 16:27:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x835.google.com with SMTP id l11so2642112qtp.0 for ; Thu, 29 Nov 2018 08:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X5Lex0gDd5Hm9JlwmnmXJK8dZysGHWIllzfXyh5afjs=; b=WJHaLo9gjqnFUuk4beU68l4hNup+BOfHm+LGFvJZeoLPTZfiQOnZ/x5IgB/MPFpzGj XK31X/KPfBjdpCAbopWLJXT3XdmymMkG06JQw5iMSYabg9D1nD0aBDTtWI5rcHVu6vFz iZCMYFvjyT1HDfzU2RsmklsHaV5NQCojS2TAlrC/rVvnKNYpDv+NuKzAAmvBJOUTVTJF U4z6gwV/7AmOMz5J3aiuuQYbOemJvu152IqSgqTmm0TtHRy9LHZMCDTXIMrrGAaH6Frn nIJn1+uzbAHEXnBsAjhseuO1p7jOh7APN1YuhmLpOMfKpR0RQeFbWjn6TOauFxNyg7tY aKrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X5Lex0gDd5Hm9JlwmnmXJK8dZysGHWIllzfXyh5afjs=; b=KIKtgWFyXDlBaUd58FIprRWZWvLN/nXmgI4ZwVl6WzbkG4pNAfZofWycABGMdfGu6l PVgnkaT0VDT2fjyy1QEEmqMTcOzcw/WFdhTO5p9M6E6X5DCWGJxk3AwnSwi0lfwIzKTj JSgoIezXfdHbGKb9Tj5u7FBdYousTy4ZYDHrx0cvE//kOHEBnLdWrECV6WI5A5Zn3aVQ CxffP3qYY6rbxrVX0FpN3vhpw+klFU1oYhrjdyII+1X8H7KUvukoXKqtfmeQpDvufB3B Sl8Dro13bK3eobESjlZCix47oNEzu70Bx8WebSb7K6LKBgMsOivx5AMNQsruvJLvJPgN F7/A== X-Gm-Message-State: AA+aEWalnwXkqLNqCL4tl16jplD+5UgoY3eSjhO5TQqPxWtkCGFhV6Kg gISp/aQJIKjYN+DRy2kzvcWQdWXXWb/8r8XpBDzvPw== X-Google-Smtp-Source: AFSGD/WvZNBC9cjAWvj87QfuMPAJeNTkeXv50PUus8oi+t+8+iprbTffqeHxSrZMyXUXYAEhZGcMFbY5xir92kh1WmA= X-Received: by 2002:ac8:4294:: with SMTP id o20mr2103600qtl.118.1543508865427; Thu, 29 Nov 2018 08:27:45 -0800 (PST) MIME-Version: 1.0 References: <201811291449.wATEnXIY072818@repo.freebsd.org> In-Reply-To: <201811291449.wATEnXIY072818@repo.freebsd.org> From: Warner Losh Date: Thu, 29 Nov 2018 09:27:34 -0700 Message-ID: Subject: Re: svn commit: r341233 - head/usr.bin/trim To: Eugene Grosbein Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: EC68773905 X-Spamd-Result: default: False [-3.62 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.997,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[5.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.63)[ipnet: 2607:f8b0::/32(-1.74), asn: 15169(-1.33), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 16:27:46 -0000 On Thu, Nov 29, 2018 at 7:49 AM Eugene Grosbein wrote: > Author: eugen > Date: Thu Nov 29 14:49:33 2018 > New Revision: 341233 > URL: https://svnweb.freebsd.org/changeset/base/341233 > > Log: > trim(1): unbreak build after r341232 for platforms using gcc and not > clang > > MFC after: 1 month > > Modified: > head/usr.bin/trim/trim.c > > Modified: head/usr.bin/trim/trim.c > > ============================================================================== > --- head/usr.bin/trim/trim.c Thu Nov 29 14:21:26 2018 (r341232) > +++ head/usr.bin/trim/trim.c Thu Nov 29 14:49:33 2018 (r341233) > @@ -42,8 +42,10 @@ > #include > #include > > +#ifndef lint > static const char rcsid[] = > "$FreeBSD$"; > +#endif /* not lint */ > This is spelled FBSDID("$FreeBSD"); It's one of the many issues I have with the code. Should I just fix them? Warner