From owner-freebsd-current Sun Dec 1 18: 7:35 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E360337B401 for ; Sun, 1 Dec 2002 18:07:33 -0800 (PST) Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0225E43EA9 for ; Sun, 1 Dec 2002 18:07:33 -0800 (PST) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id gB227FL2340278; Sun, 1 Dec 2002 21:07:15 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <3DEA9F38.7A1F99C2@mindspring.com> References: <3DEA9F38.7A1F99C2@mindspring.com> Date: Sun, 1 Dec 2002 21:07:13 -0500 To: Terry Lambert , Nate Lawson From: Garance A Drosihn Subject: Re: Trivial patch: fdisk doesn't recognize my partitions Cc: Poul-Henning Kamp , Riccardo Torrini , freebsd-current@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 3:46 PM -0800 12/1/02, Terry Lambert wrote: >[ ... Partition ID changes ... ] > > > > But as I said, this is rather marginal and I really don't > > > feel it should go in unless this xor-0x10 convention is > > > more widespread. > > > > partition magic does this too. isn't the correct failure mode > > just to print the part. id in hex instead of expanding it? > > >Frankly, who cares? > >You guys still haven't told us, if these partitions are being >hidden... WHY ARE WE NOT RESPECTING THE DECISION TO HIDE THE >THINGS? A user installed the software doing the hiding on >purpose. The software changed the ID hide it, on purpose. >Windows ignores these partitions -- on purpose. Well, all Nate said was "print the field in hex". That seems like the right thing to do, and it has nothing to do with this hiding scheme. My own opinion is that if I have explicitly hid a partition, then freebsd should ignore it. There are times that I do this specifically so *freebsd* will ignore it, and I don't want freebsd trying to second-guess what I meant. >If you're going that route, why does FreeBSD care about partition >ID at all? All it is is a *hint*; it's not definitive. It's not >lika a protocol type encapsulation on a packet. > >It doesn't matter what the ID says, the rest of the partition >table entry demarcates a region of a linear arraw of bytes that >contain data. > >I think looking at the content of that linear array is what >should determine what the content is, in the absence of a valid >"hint". > >Specifically, if it has a valid disklabel on the thing, I don't >care what partition ID it has on it, I give it to the disklabel >handler. If it has a valid FAT32 FS on it, I give it to the >FAT32FS. If it has a valid FFS superblock on it, I give it to >FFS. Etc.. The fact that the disklabel is valid does not mean that the filesystem in that partition is still valid. If I hide a partition, it may be that I had a very good reason for hiding it, and freebsd shouldn't be "giving it" to anything when the partition ID is not a recognized ID. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message