From owner-svn-src-stable-10@FreeBSD.ORG  Sat Apr  4 09:16:31 2015
Return-Path: <owner-svn-src-stable-10@FreeBSD.ORG>
Delivered-To: svn-src-stable-10@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3821B976;
 Sat,  4 Apr 2015 09:16:31 +0000 (UTC)
Received: from mail-ig0-x22d.google.com (mail-ig0-x22d.google.com
 [IPv6:2607:f8b0:4001:c05::22d])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id F252FDAA;
 Sat,  4 Apr 2015 09:16:30 +0000 (UTC)
Received: by igcau2 with SMTP id au2so76216717igc.1;
 Sat, 04 Apr 2015 02:16:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=RRrvXmaTF0Z/Sz9US2UYXNadbhowYIC0l5aFd8BC+Cs=;
 b=eAj93gsAU3TByhh7v7+3Lr6CA91n9oEztwAZ5Sx1APkEf0AVvCN5Xh6XZ1B4aI0acq
 xlRFBXjQZq4y0O693KtG0J4VdhcLC56tZa8gvh3Ycz7mieN8toK0C9uW54N1O37Y/fVw
 knbjzAOaJdRqB4/2R8hGBGIknlqeiILL9Vmyy6BrgT7UoS2j0BNhWBdwvaM9lXnL1/Je
 2ahnKVGULeq5ep8gbAEAoHcUCY+BgtIiUVqbsAJ+RoEd2hYeg4zyim/PdkcXXbVGBDae
 Jjwg8+twjYSa6+GUnhw4FgByIYJCNRTWtFIi/aQj+J5Vr9fNrv7o/xbY5P0Ztw6iueVf
 qynQ==
MIME-Version: 1.0
X-Received: by 10.107.130.145 with SMTP id m17mr8808061ioi.89.1428138990391;
 Sat, 04 Apr 2015 02:16:30 -0700 (PDT)
Sender: edschouten@gmail.com
Received: by 10.107.130.163 with HTTP; Sat, 4 Apr 2015 02:16:30 -0700 (PDT)
In-Reply-To: <201503110949.t2B9n7Yk000610@svn.freebsd.org>
References: <201503110949.t2B9n7Yk000610@svn.freebsd.org>
Date: Sat, 4 Apr 2015 11:16:30 +0200
X-Google-Sender-Auth: x200zObPe15Tzo8yGgqzBVu5w1s
Message-ID: <CAJOYFBBSn7GxzZS0hXzD03M-u_MQnjXFf9wDxxWO4TZWHSnynw@mail.gmail.com>
Subject: Re: svn commit: r279877 - stable/10/sys/boot/fdt
From: Ed Schouten <ed@80386.nl>
To: Alexander Motin <mav@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, svn-src-stable-10@freebsd.org
X-BeenThere: svn-src-stable-10@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for only the 10-stable src tree
 <svn-src-stable-10.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-10/>
List-Post: <mailto:svn-src-stable-10@freebsd.org>
List-Help: <mailto:svn-src-stable-10-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10>, 
 <mailto:svn-src-stable-10-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Apr 2015 09:16:31 -0000

Hi Alexander,

Quick question:

2015-03-11 10:49 GMT+01:00 Alexander Motin <mav@freebsd.org>:
>         buf = (char *)malloc(sizeof(char) * sz);
> -       bzero(buf, sizeof(char) * sz);
> -
>         if (buf == NULL) {
>                 sprintf(command_errbuf, "could not allocate space "
>                     "for string");
>                 return (1);
>         }
> +       bzero(buf, sizeof(char) * sz);
>
>         idx = 0;
>         for (i = start, idx = 0; i < argc; i++) {
>

Couldn't this use calloc() instead?

Thanks,
-- 
Ed Schouten <ed@80386.nl>