Date: Wed, 17 Jan 2018 11:49:13 -0700 From: Adam Weinberger <adamw@adamw.org> To: =?utf-8?Q?Martin_Waschb=C3=BCsch?= <martin@waschbuesch.de> Cc: Freddie Cash <fjwcash@gmail.com>, freebsd-ports <freebsd-ports@freebsd.org> Subject: Re: Help with versioning scheme Message-ID: <2332F791-ACC9-4407-99AF-C184CB1BC55E@adamw.org> In-Reply-To: <638AE69B-CB7C-41E1-9CA8-D0B9E2A6BC32@waschbuesch.de> References: <F35F7011-4DDA-4BD4-93FB-BE75ECD49827@waschbuesch.de> <C655A3CB-8C52-4CB0-A6F4-F34EAD224175@adamw.org> <D3D2C74D-DA67-4B8D-96C3-4E1E2928D815@waschbuesch.de> <CAOjFWZ7xMcSQWRYAfaSA%2Baxm9de9bdsikqRZJfZXbsEb8%2B_oSg@mail.gmail.com> <638AE69B-CB7C-41E1-9CA8-D0B9E2A6BC32@waschbuesch.de>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 17 Jan, 2018, at 11:40, Martin Waschbüsch <martin@waschbuesch.de> wrote:
>
> Thanks, Freddie,
>> Am 17.01.2018 um 19:35 schrieb Freddie Cash <fjwcash@gmail.com>:
>>
>> On Wed, Jan 17, 2018 at 10:29 AM, Martin Waschbüsch
>> <martin@waschbuesch.de <mailto:martin@waschbuesch.de>> wrote:
>> Hi Adam,
>>> Am 17.01.2018 um 19:19 schrieb Adam Weinberger <adamw@adamw.org
>>> <mailto:adamw@adamw.org>>:
>>> Hi Martin,
>>>
>>> You don't want to use the upstream version to represent PORTREVISION.
>>> PORTREVISION is for when you need to force rebuilds of the port itself,
>>> and so tying it to upstream would make it impossible to bump it
>>> ourselves.
>>>
>>> Why do you need to ignore the fourth digit? It's perfectly valid for
>>> our purposes.
>>
>> So far, I had (because it coincided with their version number) used it
>> to provide SO_VER. But that breaks now:
>>
>> ---
>> # Created by: adamw
>> # $FreeBSD: head/archivers/liblz4/Makefile 448415 2017-08-20 12:30:25Z
>> sunpoet $
>>
>> PORTNAME= lz4
>> PORTVERSION= 1.8.1
>> DISTVERSIONPREFIX= v
>> PORTEPOCH= 1
>> CATEGORIES= archivers
>> PKGNAMEPREFIX= lib
>>
>> MAINTAINER= martin@waschbuesch.de <mailto:martin@waschbuesch.de>
>> COMMENT= LZ4 compression library, lossless and very fast
>>
>> LICENSE= BSD2CLAUSE GPLv2
>> LICENSE_COMB= multi
>>
>> USES= gmake pathfix pkgconfig
>> USE_GITHUB= yes
>> USE_LDCONFIG= yes
>> #PATHFIX_MAKEFILEIN= Makefile
>>
>> ALL_TARGET= default # don't remove this
>> SO_VER= ${PORTVERSION}
>> PLIST_SUB+= SO_VER=${SO_VER} SO_VER_MAJ=${SO_VER:R:R}
>>
>> Why can't you do something like the above to get SO_VER?
>>
>> PORTVERSION=1.8.1.2
>> SO_VER=${PORTVERSION:R:R:R)
>>
>> Similar to how you get SO_VER_MAJ out of SO_VER.
>
> That is true. Do you think this is a robust solution, though?
> Or is the whole relying on upstream variables idea problematic?
In general, I recommend against doing clever things. It's too easy to
outsmart yourself.
It's not terribly difficult to edit the plist and increase a number. I
recommend clear over clever every time.
# Adam
--
Adam Weinberger
adamw@adamw.org
http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2332F791-ACC9-4407-99AF-C184CB1BC55E>