From owner-svn-src-head@freebsd.org Sat May 25 03:22:29 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 879CE15965FE; Sat, 25 May 2019 03:22:29 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE0EE8B623; Sat, 25 May 2019 03:22:28 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-lj1-x241.google.com with SMTP id h19so1879826ljj.4; Fri, 24 May 2019 20:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0rfwTA5D6abBPRymgxWYmeKUyqnokJN3rrRlJ9MjgZs=; b=G/43IcB27uem5CgGaoJ8vBwLZ78C4EISQNkHkkEe5pQiDvfYKrNCaz2+4d+8i+Zmlt W3GWYLPWiW7qW7/e3sCpiQyno+24w3f9U8AADtavp996O3MSaUUnEELKhO3myzAQykHP Ix94lV2f60bAvTERV/E00XY+v/yOIT+iwB+HXAigU2WZ576VL2S3aUTwvTzJiuX0ZOfH c9Y9B25BBo5PF6GoiWvijEi3rhSNDvCWW6ZE9PlafSpt97GxxXv/H9K1zjPbk7tdd7/6 KffJIEq1Qqm6RRth6flKG57PMzyd5Nk1LEoDxxEOyPcVXVx5bm7KfE+k68cGdyDgofHy zxBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0rfwTA5D6abBPRymgxWYmeKUyqnokJN3rrRlJ9MjgZs=; b=FpmL6tkMjU0AShFoGTZu0L//Do4WcX/s8QYXwTAfcyqokM83ilULpb8frvt4AS87qv IXMZ7BG9CKdozwhG0yCO0yrLKAldskeIM10hox3m2qz3MGeOPO4MLwZhRGROoKUlaqc1 /K53Gi3mJUrzoNoc8bC2MsR7B7oGdbaNqeuxNk+BDPYMpoImfwt+299VHv711+KmLORa Fe7vg4CwigNjbfvzc68CgNejN49yXnk6Tn/p6dI2hLB9i/rqRgcaXps1vVVkcobXOHAE b31pYu8whq/XcFipEIr2UcpqHN/1ORDrgebwviV/1c0SXOTH8CyXE8pFZiCZPO/3jodg kwJw== X-Gm-Message-State: APjAAAXQxpAX5qebzATjOMx1umd64kpSDeHRzNNMvb3ZFgnW4CKL5m5Z 2aezXd9V+YD9K2z/aWpiZxV60NG1N/mDaoLMeCyydm0t X-Google-Smtp-Source: APXvYqyGCBJdRGpM8ATb94YcJdnYknqOdoyjQnAwGHK08hr8WzofA49hBG74y01z2FhLw3xKj1lZyaZJ7TjVMxuUVeg= X-Received: by 2002:a2e:8716:: with SMTP id m22mr2512034lji.128.1558754546785; Fri, 24 May 2019 20:22:26 -0700 (PDT) MIME-Version: 1.0 References: <201905250302.x4P32V8m099331@gndrsh.dnsmgr.net> In-Reply-To: <201905250302.x4P32V8m099331@gndrsh.dnsmgr.net> From: Justin Hibbits Date: Fri, 24 May 2019 22:22:13 -0500 Message-ID: Subject: Re: svn commit: r348250 - head/sys/powerpc/conf To: rgrimes@freebsd.org Cc: Alexey Dokuchaev , Piotr Kubaj , svn-src-head , svn-src-all , src-committers Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EE0EE8B623 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 May 2019 03:22:29 -0000 On Fri, May 24, 2019 at 10:02 PM Rodney W. Grimes wrote: > > > On Fri, May 24, 2019 at 6:01 PM Rodney W. Grimes > > wrote: > > > > > > > On Fri, 24 May 2019 20:22:52 +0000 > > > > Alexey Dokuchaev wrote: > > > > > > > > > On Fri, May 24, 2019 at 03:16:51PM -0500, Justin Hibbits wrote: > > > > > > On Fri, 24 May 2019 20:01:59 +0000 (UTC) Piotr Kubaj wrote: > > > > > > > New Revision: 348250 > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/348250 > > > > > > > > > > > > > > Log: > > > > > > > Add snd_hda(4) to GENERIC64 used by powerpc64. > > > > > > > > > > > > > > amd64 also has snd_hda(4) in GENERIC. > > > > > > > > > > > > > > Modified: > > > > > > > head/sys/powerpc/conf/GENERIC64 > > > > > > > ... > > > > > > > > > > > > To note: This was done because there's a strange bug in the snd_hda > > > > > > module, with the hdaa component. For some reason it either doesn't > > > > > > find all the internal components it needs, or something, because > > > > > > there's a NULL dereference when trying to call a kobj method in > > > > > > hdaa_attach(). > > > > > > > > > > So this commit essentially masks the real bug somewhere rather than > > > > > fixing it, is this what you're saying? > > > > > > > > > > ./danfe > > > > > > > > It's a viable workaround to a problem that reaches a wide audience. > > > > Since it works built-in, I found it acceptable. I probably should have > > > > filed a bug for it a year ago when I hit it and worked around it, but it > > > > could also very well be a compiler issue. > > > > > > > > By the way, it works fine on powerpc (32-bit) loaded as a module. > > > > > > Please do file a bug report now, please do mark the line in GENERIC64 with > > > a comment XXX This is needed to work around foo so that it is documented > > > why it is there and someone removing it does not go down a rabit > > > hole others have already been down, and so that some day someone > > > may go down that rabbit hole of there own free will and fix this > > > for us. > > > > > > Paving over the top of obscure bugs with a hackish fix is ok, > > > not documenting this state of affairs is not, IMHO. > > > > > > > - Justin > > > -- > > > Rod Grimes rgrimes@freebsd.org > > > > Bug filed as kern/238113. I don't think a XXX is necessarily needed > > in GENERIC64, since it's also parity with GENERIC on amd64. > > Does the bug also exist on amd64? No idea. I don't have any amd64 hardware, and it's been in GENERIC for as long as I know. My unfounded guess is that it doesn't exist on amd64, but someone else would have to confirm that. - Justin