Date: Wed, 27 Aug 2014 07:43:02 +0000 From: "Eggert, Lars" <lars@netapp.com> To: Adrian Chadd <adrian@freebsd.org> Cc: Tom Jones <jones@sdf.org>, FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: Patches for RFC6937 and draft-ietf-tcpm-newcwv-00 Message-ID: <3ABE6D0D-1D98-425B-BDAD-8D1B9026AD8F@netapp.com> In-Reply-To: <CAJ-VmokSzvGyUnSkakrgxizQ1xXOMQgzrXKQMTUuFAZOMG0W=g@mail.gmail.com> References: <259C9434-C6FE-42EA-823D-ECB024DBF3D7@netapp.com> <B7145157-9A03-4053-BFCC-627633E20122@neville-neil.com> <814E0886-1B6B-4316-8BAB-684DAFDE1983@netapp.com> <20140826145517.GD12732@gmail.com> <CAJ-Vmo=TsqAKUrV3BRAk1bX9E1zKq7j5og5CHv4PEz-9sqXpAA@mail.gmail.com> <76D986F7-72A8-4ABE-8731-064C6C77A56F@netapp.com> <CAJ-VmokSzvGyUnSkakrgxizQ1xXOMQgzrXKQMTUuFAZOMG0W=g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_B40EEF84-05A0-45D6-8457-EA5FDB56EA5D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Not as far as I know.=20 Lars On 2014-8-27, at 9:39, Adrian Chadd <adrian@freebsd.org> wrote: > Is there a PR for it? >=20 >=20 > -a >=20 >=20 > On 27 August 2014 00:23, Eggert, Lars <lars@netapp.com> wrote: >> It would be great if people could also review Aris' PRR patch - = RFC6937 has been out for a while. >>=20 >> Lars >>=20 >>=20 >>=20 >>=20 >> On 2014-8-26, at 20:09, Adrian Chadd <adrian@freebsd.org> wrote: >>=20 >>> Hi! >>>=20 >>> I'm going to merge Tom's work in a week unless someone gives me a >>> really good reason not to. >>>=20 >>> I think there's been enough work and discussion about it since the >>> first post from Lars in Feburary and enough review opportunity. >>>=20 >>>=20 >>> -a >>>=20 >>>=20 >>> On 26 August 2014 07:55, Tom Jones <jones@sdf.org> wrote: >>>> On Tue, Aug 26, 2014 at 02:43:49PM +0000, Eggert, Lars wrote: >>>>> Hi, >>>>>=20 >>>>> the newcwv patch is probably stale now with Tom Jones' recent = patch based on >>>>> a more up-to-date version of the Internet-Draft, but the PRR patch = should >>>>> still be useful? >>>>=20 >>>> My newcwv patch is much more up to date than Aris's, but it is = slightly >>>> different in implementation. I have had a few suggestions from = Adrian, but he >>>> couldn't comment on how it relates to the tcp internals. >>>>=20 >>>> There is a PR: = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D191520 >>>>=20 >>>> The biggest difference in structure between mine and Aris's patch = is the use of >>>> tcp timers. It would be good to hear if my approach or Aris's is = prefered. >>>>=20 >>>>> On 2014-6-19, at 23:35, George Neville-Neil <gnn@neville-neil.com> = wrote: >>>>>=20 >>>>>> On 4 Feb 2014, at 1:38, Eggert, Lars wrote: >>>>>>=20 >>>>>>> Hi, >>>>>>>=20 >>>>>>> below are two patches that implement RFC6937 ("Proportional Rate = Reduction for TCP") and draft-ietf-tcpm-newcwv-00 ("Updating TCP to = support Rate-Limited Traffic"). They were done by Aris = Angelogiannopoulos for his MS thesis, which is at = https://eggert.org/students/angelogiannopoulos-thesis.pdf. >>>>>>>=20 >>>>>>> The patches should apply to -CURRENT as of Sep 17, 2013. (Sorry = for the delay in sending them, we'd been trying to get some feedback = from committers first, without luck.) >>>>>>>=20 >>>>>>> Please note that newcwv is still a work in progress in the IETF, = and the patch has some limitations with regards to the "pipeACK Sampling = Period" mentioned in the Internet-Draft. Aris says this in his thesis = about what exactly he implemented: >>>>>>>=20 >>>>>>> "The second implementation choice, is in regards with the = measurement of pipeACK. This variable is the most important introduced = by the method and is used to compute the phase that the sender currently = lies in. In order to compute pipeACK the approach suggested by the = Internet Draft (ID) is followed [ncwv]. During initialization, pipeACK = is set to the maximum possible value. A helper variable prevHighACK is = introduced that is initialized to the initial sequence number (iss). = prevHighACK holds the value of the highest acknowledged byte so far. = pipeACK is measured once per RTT meaning that when an ACK covering = prevHighACK is received, pipeACK becomes the difference between the = current ACK and prevHighACK. This is called a pipeACK sample. A newer = version of the draft suggests that multiple pipeACK samples can be used = during the pipeACK sampling period." >>>>>>>=20 >>>>>>> Lars >>>>>>>=20 >>>>>>>=20 >>>>>>> [prr.patch] >>>>>>>=20 >>>>>>> [newcwv.patch] >>>>>>=20 >>>>>> Apologies for not looking at this as yet. It is now closer to = the top of my list. >>>>>>=20 >>>>>> Best, >>>>>> George >>>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> -- >>>> Tom >>>> @adventureloop >>>> adventurist.me >>>>=20 >>>> :wq >>>> _______________________________________________ >>>> freebsd-net@freebsd.org mailing list >>>> http://lists.freebsd.org/mailman/listinfo/freebsd-net >>>> To unsubscribe, send any mail to = "freebsd-net-unsubscribe@freebsd.org" >>=20 >>=20 --Apple-Mail=_B40EEF84-05A0-45D6-8457-EA5FDB56EA5D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- iQCVAwUBU/2MG9ZcnpRveo1xAQI53gQAnUWBtbU+drMUeHD6tdcHrHz8nItQ+cQv qYoH6nntPec/Bm0eBRRzG/e3nf8zbPevMiR+e22NrG1K6ugy+/UA4PjlSm3tAbuv edspyINmG5rYC5PpVCWelk6wvhX52WM/wmYzfPpwYp9AAwc8xneb5Olm+Ceuuq0x U7OMGiaC51I= =1HcZ -----END PGP SIGNATURE----- --Apple-Mail=_B40EEF84-05A0-45D6-8457-EA5FDB56EA5D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3ABE6D0D-1D98-425B-BDAD-8D1B9026AD8F>